Bug 10989

Summary: Provide a way for embedders to implement BrowserExtensionWin
Product: WebKit Reporter: Brett Wilson (Google) <brettw>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch to forward to the UIDelegate
darin: review+
Patch with changelog none

Brett Wilson (Google)
Reported 2006-09-22 13:11:32 PDT
Important things like window.open() are provided by the interface BrowserExtensionWin. All functions in this class on Windows are currently stubbed out in TemporaryLinkStubs. There should be a way for embedders to provide implementations of these things.
Attachments
Patch to forward to the UIDelegate (9.72 KB, patch)
2006-10-02 14:19 PDT, Brett Wilson (Google) 		darin: review+
DetailsFormatted DiffDiff
Patch with changelog (13.43 KB, patch)
2006-10-05 11:13 PDT, Brett Wilson (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brett Wilson (Google)
Comment 1 2006-10-02 14:19:55 PDT
Created attachment 10873 [details] Patch to forward to the UIDelegate This patch is based on DarinA and Maciej's help. This adds a new file for BrowserExtensionWin where the TemporaryLinkStubs functions have been moved, and hooks up the createNewWindow calls (the rest remain the same stubs as in TemporaryLinkStubs). They are forwarded to the FrameWin, which then forwards them to the WebFrame. The WebFrame then calls the UIDelegate (if any) provided by the embedder. The IDL declaration of the retval of IWebUIDelegate::createWebViewWithRequest seemed to be incorrect, so this also fixes that.
Darin Adler
Comment 2 2006-10-02 19:37:17 PDT
Comment on attachment 10873 [details] Patch to forward to the UIDelegate Looks fine. r=me
Brett Wilson (Google)
Comment 3 2006-10-05 11:13:57 PDT
Created attachment 10931 [details] Patch with changelog
Alexey Proskuryakov
Comment 4 2006-10-05 13:27:28 PDT
Committed revision 16817.
Note You need to log in before you can comment on or make changes to this bug.