Summary: | [CSS Exclusions] Enable shape-inside support for ellipses | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hans Muller <giles_joplin> | ||||||||||||||
Component: | CSS | Assignee: | Hans Muller <giles_joplin> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | eric, esprehn+autocc, ojan.autocc, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 89707 | ||||||||||||||||
Attachments: |
|
Description
Hans Muller
2013-02-14 15:39:55 PST
Created attachment 188627 [details]
Patch
Created attachment 188631 [details]
Patch
Added ChangeLog changes.
Comment on attachment 188631 [details] Patch Rejecting attachment 188631 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 188631, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: e LayoutTests/fast/exclusions/shape-inside/shape-inside-ellipse.html patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/ExclusionShapeInsideInfo.h Hunk #1 FAILED at 58. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/ExclusionShapeInsideInfo.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Dirk Schulze']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16626709 Created attachment 189106 [details]
Patch
Resolved patch relative to the latest version of ExclusionShapeInsideInfo.h.
Created attachment 189173 [details]
Patch
Updated ChangeLogs, listed Dirk as the reviewer.
Comment on attachment 189173 [details] Patch Rejecting attachment 189173 [details] from commit-queue. giles_joplin@yahoo.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. (In reply to comment #6) > (From update of attachment 189173 [details]) > Rejecting attachment 189173 [details] from commit-queue. > > giles_joplin@yahoo.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. I've corrected the email address in committers.py. Created attachment 189202 [details]
Patch
Retry commit now that the committers.py file has been corrected.
Comment on attachment 189202 [details] Patch Rejecting attachment 189202 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 189202, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue ChangeLog entry in LayoutTests/ChangeLog is not at the top of the file. Full output: http://queues.webkit.org/results/16627879 Created attachment 189207 [details]
Patch
Moved ChangeLog entries to the top of the file.
Comment on attachment 189207 [details] Patch Clearing flags on attachment: 189207 Committed r143420: <http://trac.webkit.org/changeset/143420> All reviewed patches have been landed. Closing bug. |