Summary: | AX: Mac platform should support ability to scroll an element into visible | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, apinheiro, bdakin, dmazzoni, jdiggs, rniwa, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
chris fleizach
2013-02-14 14:02:34 PST
Created attachment 188421 [details]
patch
Have you tried running any of the layout tests I wrote for scrollToMakeVisible in platform/chromium/accessibility? It'd be nice if you could move one or more of those to be a cross-platform test. (In reply to comment #2) > Have you tried running any of the layout tests I wrote for scrollToMakeVisible in platform/chromium/accessibility? It'd be nice if you could move one or more of those to be a cross-platform test. Good idea. I haven't done that, but I filed a bug to look into it for a future patch https://bugs.webkit.org/show_bug.cgi?id=110287 Thanks. Unofficial review, looks good. Comment on attachment 188421 [details] patch Rejecting attachment 188421 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 188421, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: cessibilityUIElementMac.mm patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/mac/accessibility/scroll-to-visible-action-expected.txt patching file LayoutTests/platform/mac/accessibility/scroll-to-visible-action.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Beth Dakin']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://webkit-commit-queue.appspot.com/results/16753089 |