Bug 109855

Summary:

[BlackBerry] requireAuth parameter of NetworkJob is redundant

Product:

WebKit

Reporter:

Joe Mason <joenotcharles>

Component:

Page Loading

Assignee:

Joe Mason <joenotcharles>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

buildbot, mifenton, rniwa, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Unspecified

Bug Depends on:

109751

Bug Blocks:

Attachments:

Description	Flags
fix	joenotcharles: review-
fix	yong.li.webkit: review+, webkit.review.bot: commit-queue-
rebased fix	none

Joe Mason

Reported 2013-02-14 13:22:06 PST

The requireAuth parameter of NetworkJob::notifyAuthReceived is redundant as its value can be determined from "result" - if result is AuthResultRetry, requireAuth is false, otherwise it is true. For code cleanup it should be removed.

Attachments
fix (4.22 KB, patch) 2013-02-14 14:33 PST, Joe Mason	joenotcharles: review-	Details Formatted Diff Diff
fix (4.22 KB, patch) 2013-02-14 14:35 PST, Joe Mason	yong.li.webkit: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
rebased fix (4.25 KB, patch) 2013-02-14 16:02 PST, Joe Mason	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Joe Mason

Comment 1 2013-02-14 14:33:06 PST

Created attachment 188430 [details] fix

Joe Mason

Comment 2 2013-02-14 14:33:53 PST

Comment on attachment 188430 [details] fix changelog has the wrong PR number. Not sure how that happened

Joe Mason

Comment 3 2013-02-14 14:35:12 PST

Created attachment 188431 [details] fix

WebKit Review Bot

Comment 4 2013-02-14 14:41:26 PST

Comment on attachment 188431 [details] fix Rejecting attachment 188431 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 188431, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ile Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/network/blackberry/NetworkJob.cpp Hunk #2 FAILED at 355. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/network/blackberry/NetworkJob.cpp.rej patching file Source/WebCore/platform/network/blackberry/NetworkJob.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Yong Li']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16542754

Joe Mason

Comment 5 2013-02-14 14:45:27 PST

Seems we forgot to upstream something.

Joe Mason

Comment 6 2013-02-14 14:47:53 PST

I didn't realize https://bugs.webkit.org/show_bug.cgi?id=109751 isn't reviewed and committed yet

Joe Mason

Comment 7 2013-02-14 16:02:18 PST

Created attachment 188442 [details] rebased fix

Build Bot

Comment 8 2013-02-14 20:48:47 PST

Comment on attachment 188442 [details] rebased fix Attachment 188442 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16537922 New failing tests: media/video-controls-captions-trackmenu.html

WebKit Review Bot

Comment 9 2013-02-15 07:27:21 PST

Comment on attachment 188442 [details] rebased fix Clearing flags on attachment: 188442 Committed r142996: <http://trac.webkit.org/changeset/142996>

WebKit Review Bot

Comment 10 2013-02-15 07:27:25 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.