Bug 109821 – TextTrackCue Extension for WebVTT Regions

• Component: Media
• Status: RESOLVED FIXED

[Victor Carbune]

The TextTrackCue object and settings are extended with:
Parsing (support for region identifier) and JavaScript (regionId attribute)

[Glenn Adams]

propose to the W3C for standardization, and, if they accept and specify, then you may reopen this bug

[Eric Carlson]

As noted in the master bug (#109570), there is a proposed solution [1] [2] which has had a great deal of discussion in the text community group mailing list (eg. [3]).

[1] https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/region.html
[2] http://www.w3.org/community/texttracks/wiki/MultiCueBox
[3] http://lists.w3.org/Archives/Public/public-texttracks/2012Dec/0000.html

[Victor Carbune]

Created attachment 195975 [details]
Patch and Test

[WebKit Review Bot]

Comment on attachment 195975 [details]
Patch and Test

Attachment 195975 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17390020

[Eric Carlson]

View in context: https://bugs.webkit.org/attachment.cgi?id=195975&action=review

> Source/WebCore/html/track/TextTrackCue.cpp:208
> +    , m_regionId(emptyString())

This isn't necessary, the compiler automatically calls the default constructor.

> Source/WebCore/html/track/TextTrackCue.cpp:1105
> +    if (m_regionId == emptyString())

if (!m_regionId.isEmpty())

[WebKit Review Bot]

Comment on attachment 195975 [details]
Patch and Test

Attachment 195975 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17230972

[Peter Beverloo (cr-android ews)]

Comment on attachment 195975 [details]
Patch and Test

Attachment 195975 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17230970

[Build Bot]

Comment on attachment 195975 [details]
Patch and Test

Attachment 195975 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17337455

[Victor Carbune]

Created attachment 195982 [details]
Updated Patch

[Victor Carbune]

(In reply to comment #5)
> View in context: https://bugs.webkit.org/attachment.cgi?id=195975&action=review
> 
> > Source/WebCore/html/track/TextTrackCue.cpp:208
> > +    , m_regionId(emptyString())
> 
> This isn't necessary, the compiler automatically calls the default constructor.

Done.

> > Source/WebCore/html/track/TextTrackCue.cpp:1105
> > +    if (m_regionId == emptyString())
> 
> if (!m_regionId.isEmpty())

Done.

[WebKit Review Bot]

Comment on attachment 195982 [details]
Updated Patch

Attachment 195982 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17337462

[WebKit Review Bot]

Comment on attachment 195982 [details]
Updated Patch

Attachment 195982 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17336410

[Peter Beverloo (cr-android ews)]

Comment on attachment 195982 [details]
Updated Patch

Attachment 195982 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17336412

[Victor Carbune]

Created attachment 195985 [details]
Updated Patch

[WebKit Review Bot]

Comment on attachment 195985 [details]
Updated Patch

Clearing flags on attachment: 195985

Committed r147355: <http://trac.webkit.org/changeset/147355>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.