Bug 109797

Summary: [WebGL][Qt] regression:r142786 Build fix for Arm and Windows
Product: WebKit Reporter: Kalyan <kalyan.kondapally>
Component: WebKit QtAssignee: Kalyan <kalyan.kondapally>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, jturcotte, kadam, kbr, mrobinson, ossy, rgabor, webkit.review.bot, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on: 109382    
Bug Blocks:    
Attachments:
Description Flags
patch
none
patch none

Description Kalyan 2013-02-14 02:11:32 PST
Changeset 142786 has enabled support for OES_vertex_array_object. This has caused build breaks for Qt on arm and Windows platform.
Comment 1 Zoltan Arvai 2013-02-14 04:49:15 PST
Maybe some defines are also missing from OpenGLESShims.h, too.

If we add these functions to GraphicsContext3D in 
C:\WebKitBuildSlave\proba\WebKit\Source\WebCore\platform\graphics\opengl\GraphicsContext3DOpenGLCommon.cpp
can it fix the build?

I'll try it on my MSVC machine.
Comment 2 Kalyan 2013-02-14 08:43:01 PST
Created attachment 188364 [details]
patch
Comment 3 Zoltan Arvai 2013-02-14 10:15:18 PST
It builds and runs fine on Windows with MSVC :)

(In reply to comment #2)
> Created an attachment (id=188364) [details]
> wip
Comment 4 Kalyan 2013-02-14 11:24:56 PST
Created attachment 188388 [details]
patch
Comment 5 Csaba Osztrogon√°c 2013-02-14 16:03:54 PST
Comment on attachment 188388 [details]
patch

It works on ARM too. Thank for the fix, rs=me.
Comment 6 WebKit Review Bot 2013-02-14 16:36:53 PST
Comment on attachment 188388 [details]
patch

Clearing flags on attachment: 188388

Committed r142937: <http://trac.webkit.org/changeset/142937>
Comment 7 WebKit Review Bot 2013-02-14 16:36:57 PST
All reviewed patches have been landed.  Closing bug.