Bug 109783

Summary: drop-shadow filter with overflow:hidden child misbehaves
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, alexcppns, commit-queue, cristi.mihai, dino, eric, esprehn+autocc, glenn, graouts, joepeck, krit, ojan.autocc, simon.fraser, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Testcase
none
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2013-02-13 21:20:11 PST
Created attachment 188257 [details] Testcase In the attached test case, select the text. Note how random bits of shadow show up.
Attachments
Testcase (843 bytes, text/html)
2013-02-13 21:20 PST, Simon Fraser (smfr) 		no flags
Details
Patch (10.04 KB, patch)
2013-02-13 22:22 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (3.96 KB, patch)
2013-05-27 12:13 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-02-13 21:20:33 PST
<rdar://problem/13071169>
Simon Fraser (smfr)
Comment 2 2013-02-13 21:27:07 PST
Pretty sure this happens because the useClipRect flag computed here: useClipRect = !filterRenderer()->hasFilterThatMovesPixels(); isn't propagated to sublayers, so they still clip.
Simon Fraser (smfr)
Comment 3 2013-02-13 22:22:49 PST
Created attachment 188262 [details] Patch
Joseph Pecoraro
Comment 4 2013-02-13 22:32:37 PST
Comment on attachment 188262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188262&action=review > Source/WebCore/ChangeLog:9 > + for descendant layers that needed to not clipping to avoid artefacts A few typos in here. "needed to not clipping" and "artefacts" > LayoutTests/css3/filters/filter-repaint-shadow-layer-child.html:45 > + <!-- You should not seen part of a blue shadow inside the gray box. --> Typo: "should not seen part" => "should not see part"
Dean Jackson
Comment 5 2013-02-14 16:59:42 PST
Comment on attachment 188262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188262&action=review >> Source/WebCore/ChangeLog:9 >> + for descendant layers that needed to not clipping to avoid artefacts > > A few typos in here. "needed to not clipping" and "artefacts" Steady on, "artefacts" is the British spelling :)
WebKit Review Bot
Comment 6 2013-02-15 16:57:24 PST
Comment on attachment 188262 [details] Patch Clearing flags on attachment: 188262 Committed r143070: <http://trac.webkit.org/changeset/143070>
WebKit Review Bot
Comment 7 2013-02-15 16:57:29 PST
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 8 2013-02-19 22:12:22 PST
This didn't fix it entirely.
Dirk Schulze
Comment 9 2013-04-08 22:14:26 PDT
Is this big related to bug 82813 ? Can one of the bugs be closed?
Simon Fraser (smfr)
Comment 10 2013-04-09 08:55:54 PDT
No. This is a bug with the software shadow path.
zalan
Comment 11 2013-05-27 12:13:33 PDT
Created attachment 202999 [details] Patch
WebKit Commit Bot
Comment 12 2013-05-27 13:07:25 PDT
Comment on attachment 202999 [details] Patch Clearing flags on attachment: 202999 Committed r150775: <http://trac.webkit.org/changeset/150775>
WebKit Commit Bot
Comment 13 2013-05-27 13:07:30 PDT
All reviewed patches have been landed. Closing bug.
zalan
Comment 14 2013-05-28 03:14:26 PDT
*** Bug 101154 has been marked as a duplicate of this bug. ***
Alex C
Comment 15 2014-01-30 10:21:26 PST
This bug does not seem to be fixed. I am having the exact same issue.
Alex C
Comment 16 2014-01-30 10:32:35 PST
I meant same issue as this duplicate: https://bugs.webkit.org/show_bug.cgi?id=101154 (In reply to comment #15) > This bug does not seem to be fixed. I am having the exact same issue.
Antoine Quint
Comment 17 2014-01-30 14:41:22 PST
(In reply to comment #15) > This bug does not seem to be fixed. I am having the exact same issue. Do you have some reproducible steps? A test case?
Note You need to log in before you can comment on or make changes to this bug.