Bug 109776

Summary: Support both MutationObserver and WebKitMutationObserver
Product: WebKit Reporter: Elliott Sprehn <esprehn>
Component: New BugsAssignee: Elliott Sprehn <esprehn>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adamk, ojan.autocc, rafaelw, syoichi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89231    
Attachments:
Description Flags
Patch none

Elliott Sprehn
Reported 2013-02-13 17:26:17 PST
Unprefix MutationObserver constructor
Attachments
Patch (42.95 KB, patch)
2013-02-13 17:57 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Elliott Sprehn
Comment 1 2013-02-13 17:57:15 PST
Created attachment 188240 [details] Patch
Ojan Vafai
Comment 2 2013-02-13 19:55:56 PST
Comment on attachment 188240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188240&action=review > Source/WebCore/page/DOMWindow.idl:802 > + attribute MutationObserverConstructor WebKitMutationObserver; // FIXME: Add metrics to determine when we can remove this. Should we add a test that the prefixed version still works?
Elliott Sprehn
Comment 3 2013-02-13 20:17:14 PST
Comment on attachment 188240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188240&action=review >> Source/WebCore/page/DOMWindow.idl:802 >> + attribute MutationObserverConstructor WebKitMutationObserver; // FIXME: Add metrics to determine when we can remove this. > > Should we add a test that the prefixed version still works? I did, that's what the mutation-observer-prefix.html test is in the ChangeLog.
Ojan Vafai
Comment 4 2013-02-15 11:27:14 PST
Comment on attachment 188240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188240&action=review >>> Source/WebCore/page/DOMWindow.idl:802 >>> + attribute MutationObserverConstructor WebKitMutationObserver; // FIXME: Add metrics to determine when we can remove this. >> >> Should we add a test that the prefixed version still works? > > I did, that's what the mutation-observer-prefix.html test is in the ChangeLog. Ah. I missed that obviously. :)
WebKit Review Bot
Comment 5 2013-02-19 15:00:11 PST
Comment on attachment 188240 [details] Patch Clearing flags on attachment: 188240 Committed r143386: <http://trac.webkit.org/changeset/143386>
WebKit Review Bot
Comment 6 2013-02-19 15:00:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.