Bug 109772

Summary: Move computedStyleIncludingVisitedInfo from TestRunner to Internals
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gyuyoung.kim, kling, mifenton, ojan, philn, rakuco, rego+ews, rwlbuis, tonikitoo, webkit-ews, webkit.review.bot, xan.lopez, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Benjamin Poulain
Reported 2013-02-13 16:59:53 PST
Move computedStyleIncludingVisitedInfo from TestRunner to Internals
Attachments
Patch (42.31 KB, patch)
2013-02-13 17:06 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (43.72 KB, patch)
2013-02-13 17:56 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (46.14 KB, patch)
2013-02-13 20:14 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (46.70 KB, patch)
2013-02-27 20:14 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (46.57 KB, patch)
2013-03-01 22:06 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-02-13 17:06:31 PST
Created attachment 188228 [details] Patch
Early Warning System Bot
Comment 2 2013-02-13 17:26:31 PST
Comment on attachment 188228 [details] Patch Attachment 188228 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16536373
Early Warning System Bot
Comment 3 2013-02-13 17:27:19 PST
Comment on attachment 188228 [details] Patch Attachment 188228 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16570097
Benjamin Poulain
Comment 4 2013-02-13 17:56:03 PST
Created attachment 188239 [details] Patch
WebKit Review Bot
Comment 5 2013-02-13 19:48:52 PST
Comment on attachment 188239 [details] Patch Attachment 188239 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16543463 New failing tests: fast/loader/stateobjects/state-url-sets-links-visited.html
Benjamin Poulain
Comment 6 2013-02-13 20:14:00 PST
Created attachment 188254 [details] Patch
WebKit Review Bot
Comment 7 2013-02-13 21:01:16 PST
Comment on attachment 188254 [details] Patch Attachment 188254 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16570177 New failing tests: fast/loader/stateobjects/state-url-sets-links-visited.html
Benjamin Poulain
Comment 8 2013-02-14 13:16:39 PST
Comment on attachment 188254 [details] Patch Need to investigate the chromium mystery.
Benjamin Poulain
Comment 9 2013-02-14 20:37:29 PST
*** Bug 37297 has been marked as a duplicate of this bug. ***
Benjamin Poulain
Comment 10 2013-02-27 20:14:18 PST
Created attachment 190637 [details] Patch
Andreas Kling
Comment 11 2013-02-27 22:19:22 PST
Comment on attachment 190637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190637&action=review r=me. This is great. > Source/WebCore/testing/Internals.idl:37 > + CSSStyleDeclaration computedStyleIncludingVisitedInfo(in Node node) raises(DOMException); The TestRunner version took an Element argument, not a Node. I don't think that's really a problem though, computed styles can be created from nodes, so it makes sense to support this in Internals.
Benjamin Poulain
Comment 12 2013-02-27 22:40:24 PST
> The TestRunner version took an Element argument, not a Node. > I don't think that's really a problem though, computed styles can be created from nodes, so it makes sense to support this in Internals. Yup, as you say, it is intentional :) Thank you for the review. I should CC you more often instead of waiting 2 weeks for someone randomly r+ing.
Benjamin Poulain
Comment 13 2013-03-01 22:06:29 PST
Created attachment 191096 [details] Patch
Benjamin Poulain
Comment 14 2013-03-02 16:10:51 PST
Committed r144547: <http://trac.webkit.org/changeset/144547>
Note You need to log in before you can comment on or make changes to this bug.