| Summary: | Message generation should handle nested templates | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, rniwa, webkit-ews | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Anders Carlsson
2013-02-13 16:38:25 PST
Created attachment 188223 [details]
Patch
Comment on attachment 188223 [details] Patch Attachment 188223 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16527418 Created attachment 188227 [details]
Patch
Comment on attachment 188227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188227&action=review > Source/WebKit2/ChangeLog:13 > + (template_parameters): > + (class_template_headers): Maybe explain that they're mutually recursive? > Source/WebKit2/Scripts/webkit2/messages.py:376 > + return ([], [template_string]) Why don't we use dictionary for the return value instead so that we don't have to remember which one is which? Also, you don't need parenthesis here. > Source/WebKit2/Scripts/webkit2/messages.py:439 > + headers = [] How about using set() for headers so that we don't include the same header multiple times? > Source/WebKit2/Scripts/webkit2/messages.py:452 > + split = type.split('::') > + if len(split) < 2: > + continue Should we support fully qualified names like ::WTF::HashMap? Comment on attachment 188227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188227&action=review >> Source/WebKit2/ChangeLog:13 >> + (class_template_headers): > > Maybe explain that they're mutually recursive? Only class_template_headers is recursive. I’ll add that. Come to think of it, template_parameters can just call parser.split_parameters_string - I’ll do that. >> Source/WebKit2/Scripts/webkit2/messages.py:376 >> + return ([], [template_string]) > > Why don't we use dictionary for the return value instead so that we don't have to remember which one is which? > Also, you don't need parenthesis here. OK! >> Source/WebKit2/Scripts/webkit2/messages.py:439 >> + headers = [] > > How about using set() for headers so that we don't include the same header multiple times? Headers are uniqued later. >> Source/WebKit2/Scripts/webkit2/messages.py:452 >> + continue > > Should we support fully qualified names like ::WTF::HashMap? Nah, WTF:: is fine. Committed r142835: <http://trac.webkit.org/changeset/142835> |