Bug 109740

Summary: Fix debug assertion being triggered
Product: WebKit Reporter: Shawn Singh <shawnsingh>
Component: Layout and RenderingAssignee: Shawn Singh <shawnsingh>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jamesr, ojan.autocc, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Shawn Singh 2013-02-13 13:07:34 PST 
A debug assertion in RenderLayer.h is being hit when trying to access the normalFlowList when it is dirty.   Most likely this is caused by a new recursion that I added in , but I overlooked the need to call updateLayerListsIfNeeded() recursively as well.

Patch coming in a moment.  I'll ask for review later, after having a chance to verify that it stops triggering the assertion.
Comment 1 Shawn Singh 2013-02-13 13:26:34 PST 
Created attachment 188166 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-02-13 13:45:41 PST 
I see an assertion about dirty z-order lists in a hit testing code path when bringing up the inspector too. Probably unrelated, but would be nice to fix.
Comment 3 Shawn Singh 2013-02-13 15:06:06 PST 
Comment on attachment 188166 [details]
Patch

Didn't reproduce any debug assertion on chromium's inspector.  I'm building debug webkit now to try there - is there something specific that has to be done to reproduce the assertion?
Comment 4 WebKit Review Bot 2013-02-13 15:45:39 PST 
Comment on attachment 188166 [details]
Patch

Clearing flags on attachment: 188166

Committed r142815: <http://trac.webkit.org/changeset/142815>
Comment 5 WebKit Review Bot 2013-02-13 15:45:42 PST 
All reviewed patches have been landed.  Closing bug.