Bug 109726

Summary:

ForwardInt32ToDouble is not in DFG::MinifiedNode's list of relevant node types

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mario, mark.lam, mhahnenberg, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
fix	mhahnenberg: review+

Description Filip Pizlo 2013-02-13 11:55:58 PST

Patch forthcoming.

Comment 1 Filip Pizlo 2013-02-13 13:16:03 PST

This is asymptomatic because ForwardInt32ToDouble is only used in SetLocals, in which case the value is already stored to the stack.  Still, we should fix this.

Comment 2 Filip Pizlo 2013-02-13 13:16:56 PST

Reviewed by Gavin in person.

Comment 3 Filip Pizlo 2013-02-13 13:17:30 PST

Landed in http://trac.webkit.org/changeset/142780

Comment 4 Filip Pizlo 2013-02-13 14:22:35 PST

This is causing run-javascriptcore-tests failures.  Fix on the way.

Comment 5 Filip Pizlo 2013-02-13 14:29:02 PST

Created attachment 188183 [details]
fix

Comment 6 Mark Hahnenberg 2013-02-13 14:35:29 PST

Comment on attachment 188183 [details]
fix

View in context: https://bugs.webkit.org/attachment.cgi?id=188183&action=review

r=me with ChangeLog fix.

> Source/JavaScriptCore/ChangeLog:23
> +2013-02-13  Filip Pizlo  <fpizlo@apple.com>
> +
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * dfg/DFGMinifiedNode.h:
> +        (JSC::DFG::MinifiedNode::hasChild):

???

Comment 7 Filip Pizlo 2013-02-13 14:36:46 PST

(In reply to comment #6)
> (From update of attachment 188183 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=188183&action=review
> 
> r=me with ChangeLog fix.
> 
> > Source/JavaScriptCore/ChangeLog:23
> > +2013-02-13  Filip Pizlo  <fpizlo@apple.com>
> > +
> > +        Need a short description (OOPS!).
> > +        Need the bug URL (OOPS!).
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        * dfg/DFGMinifiedNode.h:
> > +        (JSC::DFG::MinifiedNode::hasChild):
> 
> ???

Removed.  I dunno what happened there.

Comment 8 Filip Pizlo 2013-02-13 14:38:01 PST

Landed in http://trac.webkit.org/changeset/142800