Bug 109702

Summary:

Add a CDMClient class which allows the CDM to query for the currently attached MediaPlayer.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddorwin, eric.carlson, feature-media-reviews, ojan.autocc, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

109644, 109739

Attachments:

Description	Flags
Patch	eric.carlson: review+

Jer Noble

Reported 2013-02-13 08:44:06 PST

Add a CDMClient class which allows the CDM to query for the currently attached MediaPlayer.

Attachments
Patch (7.33 KB, patch) 2013-02-13 16:23 PST, Jer Noble	eric.carlson: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2013-02-13 16:23:40 PST

Created attachment 188215 [details] Patch

Eric Carlson

Comment 2 2013-02-15 16:09:21 PST

Comment on attachment 188215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188215&action=review > Source/WebCore/Modules/encryptedmedia/CDM.h:50 > + virtual MediaPlayer* CDMMediaPlayer(CDM*) = 0; The upper case "CDMMediaPlayer" seems odd, "cdmMediaPlayer" maybe? Also, can it be const? > Source/WebCore/Modules/encryptedmedia/CDM.h:76 > + CDMClient* client() { return m_client; } const? > Source/WebCore/Modules/encryptedmedia/CDM.h:79 > + MediaPlayer* mediaPlayer(); Ditto. > Source/WebCore/Modules/encryptedmedia/MediaKeys.h:56 > + HTMLMediaElement* mediaElement(); const. Do you need to implement this? > Source/WebCore/Modules/encryptedmedia/MediaKeys.h:61 > + virtual MediaPlayer* CDMMediaPlayer(CDM*); OVERRIDE.

Jer Noble

Comment 3 2013-02-15 16:46:15 PST

(In reply to comment #2) > (From update of attachment 188215 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188215&action=review > > > Source/WebCore/Modules/encryptedmedia/CDM.h:50 > > + virtual MediaPlayer* CDMMediaPlayer(CDM*) = 0; > > The upper case "CDMMediaPlayer" seems odd, "cdmMediaPlayer" maybe? Also, can it be const? I'll change the case. It can be const, but that implies constness in a lot of other places (and in the CDM parameter too). > > Source/WebCore/Modules/encryptedmedia/CDM.h:76 > > + CDMClient* client() { return m_client; } > > const? Sure. > > Source/WebCore/Modules/encryptedmedia/CDM.h:79 > > + MediaPlayer* mediaPlayer(); > > Ditto. Sure, but this implies a const CDM* parameter in cdmMediaPlayer(). > > Source/WebCore/Modules/encryptedmedia/MediaKeys.h:56 > > + HTMLMediaElement* mediaElement(); > > const. > > Do you need to implement this? Not technically, but yes. (It's actually implemented in a future patch.) > > Source/WebCore/Modules/encryptedmedia/MediaKeys.h:61 > > + virtual MediaPlayer* CDMMediaPlayer(CDM*); > > OVERRIDE. OK.

Jer Noble

Comment 4 2013-02-15 17:05:10 PST

Committed r143072: <http://trac.webkit.org/changeset/143072>

Note You need to log in before you can comment on or make changes to this bug.