Summary: | Web Inspector: add experimental native heap graph to Timeline panel | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, graouts, joepeck, keishi, loislo, pfeldman, pmuellr, timothy, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Yury Semikhatsky
2013-02-13 06:15:07 PST
Created attachment 188068 [details]
Patch
Created attachment 188069 [details]
Screenshot with the patch applied
Comment on attachment 188068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188068&action=review > Source/WebCore/inspector/InspectorTimelineAgent.cpp:548 > + m_memoryAgent->getProcessMemoryDistributionMap(&map); we have null m_memoryAgent here in case of Worker. > Source/WebCore/inspector/InspectorTimelineAgent.cpp:552 > +// printf("%s -> %ld\n", it->key.ascii().data(), it->value); please remove this line Created attachment 188077 [details]
Patch
(In reply to comment #3) > (From update of attachment 188068 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188068&action=review > > > Source/WebCore/inspector/InspectorTimelineAgent.cpp:548 > > + m_memoryAgent->getProcessMemoryDistributionMap(&map); > > we have null m_memoryAgent here in case of Worker. > Done. > > Source/WebCore/inspector/InspectorTimelineAgent.cpp:552 > > +// printf("%s -> %ld\n", it->key.ascii().data(), it->value); > > please remove this line Done. Comment on attachment 188077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188077&action=review > Source/WebCore/inspector/Inspector.json:2634 > + { "name": "enabled", "type": "boolean", "description": "True to start collecting statisics on native memory usage." } Please rephrase to include the disablement (false) case > Source/WebCore/inspector/Inspector.json:2626 > + { "name": "enabled", "type": "boolean", "description": "True to start reporting DOM counters." } Please rephrase to include the stop (false) case > Source/WebCore/inspector/Inspector.json:2634 > + { "name": "enabled", "type": "boolean", "description": "True to start collecting statisics on native memory usage." } Please rephrase to include the stop (false) case > Source/WebCore/inspector/Inspector.json:2637 > + "description": "Starts sending statistics on native memory usage along with timeline events." "Starts sending" -> "Whether to send"? (In reply to comment #6) > (From update of attachment 188077 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188077&action=review > > > Source/WebCore/inspector/Inspector.json:2634 > > + { "name": "enabled", "type": "boolean", "description": "True to start collecting statisics on native memory usage." } > > Please rephrase to include the disablement (false) case > Done. > > Source/WebCore/inspector/Inspector.json:2626 > > + { "name": "enabled", "type": "boolean", "description": "True to start reporting DOM counters." } > > Please rephrase to include the stop (false) case > Done. > > Source/WebCore/inspector/Inspector.json:2634 > > + { "name": "enabled", "type": "boolean", "description": "True to start collecting statisics on native memory usage." } > > Please rephrase to include the stop (false) case > Done. > > Source/WebCore/inspector/Inspector.json:2637 > > + "description": "Starts sending statistics on native memory usage along with timeline events." > > "Starts sending" -> "Whether to send"? Done. Committed r142746: <http://trac.webkit.org/changeset/142746> Comment on attachment 188077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188077&action=review > Source/WebCore/inspector/Inspector.json:2624 > + "name": "setIncludeDomCounters", The Inspector Protocol and WebKit project consistently use "DOM" capitalization. The "Dom" here looks out of place: getDOMCounters, addDOMStorage, setDOMBreakpoint, removeDOMBreakpoint, ... Quick follow-up? |