Bug 109676 – [GTK] html5-local-storage-database-path settings not respected when having 2 views in the same process

• Component: WebKitGTK
• Status: UNCONFIRMED

[Guillaume Desmottes]

Created attachment 188043 [details]
test.html

To reproduce:
- Copy test.html to /tmp
- Build webkit.c ( gcc $(pkg-config --cflags --libs webkitgtk-3.0) webkit.c )
- Start ./a.out
- ls /tmp/badger

You should have either /tmp/badger/first or /tmp/badger/second but not both as
you'd expect. The two views actually use the same localStorage file despite
having a different html5-local-storage-database-path value.

I guess there is some race here as the path actually used may change if you
run it more than once (don't forget to erase /tmp/badger first).

I'm using webkitgtk3-1.10.2-1.fc18.x86_64 on F18.

[Guillaume Desmottes]

Created attachment 188044 [details]
webkit.c

[Gustavo Noronha (kov)]

So, I believe this won't work right, since the local storage path seems to be a page group setting in WebCore, not a per-Page setting. At the moment we do not have public API to set the page group for webviews, as well. I believe the only way to separate settings at the moment is by prefixing their key names, which is quite sucky.

How this could be made to work:

* Add API to create webview in a different page group, should be pretty simple to do, but we'd have to look into how to best model the page group in our public API - I think using a string property that gets a name should be quite enough for starters
* Move settings that are page group related to a new settings object that would be tied to a given page group instead of being per-webview

Adding Martin and Carlos to the CC since we may want to consider this for the wk2 API.

[Martin Robinson]

(In reply to comment #2)

> Adding Martin and Carlos to the CC since we may want to consider this for the wk2 API.

Carlos knows better than me, but I think that in WebKit2, page groups are modeled by WebContexts.