| Summary: | [V8] Generate wrapper methods for custom getters/setters | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
| Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||||
| Status: | RESOLVED INVALID | ||||||||
| Severity: | Normal | CC: | abarth, andersca, atwilson, dglazkov, japhet, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Kentaro Hara
2013-02-12 23:27:46 PST
Created attachment 188020 [details]
Patch
Comment on attachment 188020 [details]
Patch
ok
We might want to rename XXXAccessorGetter() to XXXAttrGetterCustom(). Comment on attachment 188020 [details] Patch Rejecting attachment 188020 [details] from commit-queue. New failing tests: http/tests/security/inactive-document-with-empty-security-origin.html Full output: http://queues.webkit.org/results/16491698 Attachment 188020 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/scripts/CodeGeneratorV8.pm', u'Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp', u'Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp']" exit_code: 1
Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp:505: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp:510: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp:136: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp:145: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 4 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 188020 [details] Patch Attachment 188020 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16546032 New failing tests: http/tests/security/inactive-document-with-empty-security-origin.html Rolled out the patch in r142737 as the patch might break chromium browser tests. Will take a detailed look tomorrow. Also, this patch was resulting in timeouts running http/tests/security/inactive-document-with-empty-security-origin.html on the chromium layout test canaries. Created attachment 188064 [details]
patch for landing
(In reply to comment #9) > Also, this patch was resulting in timeouts running http/tests/security/inactive-document-with-empty-security-origin.html on the chromium layout test canaries. Thanks. I uploaded a patch that fixes the problem. After confirming that ews bots get green, let me land it manually (to avoid style check errors). Attachment 188064 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/scripts/CodeGeneratorV8.pm', u'Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp', u'Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp']" exit_code: 1
Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp:505: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp:510: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp:136: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp:145: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 4 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Landed in r142833. V8 is gone. |