Bug 109660

Summary: Eradicate fast/js/dfg-poison-fuzz.html
Product: WebKit Reporter: Dima Gorbik <dgorbik>
Component: New BugsAssignee: Dima Gorbik <dgorbik>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, dgorbik, fpizlo, ggaren, mark.lam, mhahnenberg, msaboff, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dima Gorbik
Reported 2013-02-12 21:22:07 PST
Skipping the flacky test fast/js/dfg-poison-fuzz.html
Attachments
Patch (1.17 KB, patch)
2013-02-12 21:22 PST, Dima Gorbik 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dima Gorbik
Comment 1 2013-02-12 21:22:35 PST
Created attachment 188004 [details] Patch
WebKit Review Bot
Comment 2 2013-02-12 21:34:52 PST
Attachment 188004 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/TestExpectations']" exit_code: 1 LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 3 2013-02-12 22:01:05 PST
Comment on attachment 188004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188004&action=review > LayoutTests/platform/mac/TestExpectations:1339 > +# Timing out or crashing. > +webkit.org/b/109657 fast/js/dfg-poison-fuzz.html [ Crash Timeout Pass ] I think this needs [ Debug ]. It looks like the test works fine webkit.org/b/109657 [ Debug ] fast/js/dfg-poison-fuzz.html [ Timeout Pass ] The test seems to Pass fairly reliably in release.
Filip Pizlo
Comment 4 2013-02-12 22:17:28 PST
Actually, I haven't seen this test fail in *ages*. And I've seen a lot of DFG bugs! This is a super expensive test for one bug that used to be in the DFG but that has since been thoroughly eradicated. Likely the plethora of other DFG tests cover that bug. Heck, I'm not even sure if the code that this covers is even in the repository anymore. I will remove it.
Filip Pizlo
Comment 5 2013-02-12 22:18:05 PST
(In reply to comment #4) > Actually, I haven't seen this test fail in *ages*. And I've seen a lot of DFG bugs! > > This is a super expensive test for one bug that used to be in the DFG but that has since been thoroughly eradicated. Likely the plethora of other DFG tests cover that bug. Heck, I'm not even sure if the code that this covers is even in the repository anymore. > > I will remove it. (If anyone disagrees feel free to roll out my eradication patch.)
Filip Pizlo
Comment 6 2013-02-12 22:23:03 PST
Landed in http://trac.webkit.org/changeset/142723
Filip Pizlo
Comment 7 2013-02-12 22:23:17 PST
Comment on attachment 188004 [details] Patch Clearing flags for obsolete patch.
Note You need to log in before you can comment on or make changes to this bug.