Bug 109654

Summary:

[WK2] Remove web intents callbacks

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebKit2

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

REOPENED

Severity:

Normal

CC:

abecsi, andersca, ap, benjamin, buildbot, cgarcia, cmarcelo, gustavo, menard, mrobinson, rniwa, sam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

109716

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for ews	none

Gyuyoung Kim

Reported 2013-02-12 20:36:16 PST

Though web intent feature isn't supported anymore, some web intent callbacks aren't removed yet.

Attachments
Patch (6.15 KB, patch) 2013-02-12 20:38 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (8.60 KB, patch) 2013-02-12 21:03 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch for ews (10.04 KB, patch) 2013-02-13 00:48 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2013-02-12 20:38:00 PST

Created attachment 187998 [details] Patch

Early Warning System Bot

Comment 2 2013-02-12 20:54:10 PST

Comment on attachment 187998 [details] Patch Attachment 187998 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16483576

Gyuyoung Kim

Comment 3 2013-02-12 21:03:07 PST

Created attachment 188001 [details] Patch

WebKit Review Bot

Comment 4 2013-02-12 21:06:03 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Early Warning System Bot

Comment 5 2013-02-12 21:13:16 PST

Comment on attachment 188001 [details] Patch Attachment 188001 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16520550

EFL EWS Bot

Comment 6 2013-02-12 21:44:05 PST

Comment on attachment 188001 [details] Patch Attachment 188001 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16520567

Benjamin Poulain

Comment 7 2013-02-12 22:19:29 PST

Comment on attachment 188001 [details] Patch This is not binary compatible but if I am not mistaken, Version 2 have not been used in Mountain Lion. Please test thoroughly on Mac though.

Gyuyoung Kim

Comment 8 2013-02-12 22:37:28 PST

(In reply to comment #7) > (From update of attachment 188001 [details]) > This is not binary compatible but if I am not mistaken, Version 2 have not been used in Mountain Lion. > > Please test thoroughly on Mac though. Sure, I will land this patch after checking on efl, qt and mac. Thanks.

Build Bot

Comment 9 2013-02-12 23:49:56 PST

Comment on attachment 188001 [details] Patch Attachment 188001 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16522638

Gyuyoung Kim

Comment 10 2013-02-13 00:48:27 PST

Created attachment 188029 [details] Patch for ews

WebKit Review Bot

Comment 11 2013-02-13 04:01:28 PST

Comment on attachment 188029 [details] Patch for ews Clearing flags on attachment: 188029 Committed r142736: <http://trac.webkit.org/changeset/142736>

WebKit Review Bot

Comment 12 2013-02-13 04:01:33 PST

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 13 2013-02-13 10:47:34 PST

Re-opened since this is blocked by bug 109716

Alexey Proskuryakov

Comment 14 2013-02-13 10:55:19 PST

It is not OK to change offsets of functions in these structures if they are already used by shipping Safari. The right way to remove obsolete callbacks is to replace them with dummy entries.

Anders Carlsson

Comment 15 2013-02-13 11:08:42 PST

(In reply to comment #14) > It is not OK to change offsets of functions in these structures if they are already used by shipping Safari. The right way to remove obsolete callbacks is to replace them with dummy entries. (which i did when I removed web intents from WebKit2).

Benjamin Poulain

Comment 16 2013-02-13 11:39:09 PST

Didn't I ask you to verify bin compat on Mac? :(

Gyuyoung Kim

Comment 17 2013-02-13 17:27:39 PST

(In reply to comment #16) > Didn't I ask you to verify bin compat on Mac? :( I was crazy at a landing moment. Sorry about inconvenience. IMO, it would be better to be removed with Safari's use together. It looks there is no big meaning to add dummy callback here.

Anders Carlsson

Comment 18 2013-02-13 17:31:14 PST

(In reply to comment #17) > (In reply to comment #16) > > Didn't I ask you to verify bin compat on Mac? :( > > I was crazy at a landing moment. Sorry about inconvenience. IMO, it would be better to be removed with Safari's use together. It looks there is no big meaning to add dummy callback here. We need to keep the dummy callback around so that nightly builds of WebKit still work with the latest version of Safari shipped.

Note You need to log in before you can comment on or make changes to this bug.