Bug 109638

Summary:

Fix HTMLToken::Attribute member naming and update callsites to use Vector-based String functions

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, benjamin, darin, dbates, msaboff, ojan.autocc, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

109617

Bug Blocks:

109784

Attachments:

Description	Flags
Patch	none

Description Eric Seidel (no email) 2013-02-12 17:27:16 PST

Fix HTMLToken::Attribute member naming and update callsites to use Vector-based String functions

Comment 1 Eric Seidel (no email) 2013-02-12 17:29:16 PST

Created attachment 187974 [details]
Patch

Comment 2 WebKit Review Bot 2013-02-12 20:26:09 PST

Comment on attachment 187974 [details]
Patch

Clearing flags on attachment: 187974

Committed r142712: <http://trac.webkit.org/changeset/142712>

Comment 3 WebKit Review Bot 2013-02-12 20:26:13 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Eric Seidel (no email) 2013-02-13 21:59:54 PST

I've since learned/re-learned that this is a change in behavior.

Previously String(UChar*, length) will treat length=0 as the empty string.

String(Vector) treats vector.size() == 0 as the null string.

This patch may need to be amended.