Bug 109611 – [chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents

• Component: New Bugs
• Status: RESOLVED FIXED

[Sadrul Habib Chowdhury]

[chromium] Add unaccelerated deltas to WebMouseWheelEvent

[Sadrul Habib Chowdhury]

Created attachment 187929 [details]
Patch

[Adam Barth]

Comment on attachment 187929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187929&action=review

> Source/WebKit/chromium/ChangeLog:6
> +        Mousewheel events generated by trackpad can have accelrated deltas (e.g. when doing

typo: accelrated

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Sadrul Habib Chowdhury]

Created attachment 187932 [details]
Patch

[Sadrul Habib Chowdhury]

Comment on attachment 187929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187929&action=review

>> Source/WebKit/chromium/ChangeLog:6
>> +        Mousewheel events generated by trackpad can have accelrated deltas (e.g. when doing
> 
> typo: accelrated

Whoops. Fixed.

[Adam Barth]

Comment on attachment 187932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187932&action=review

> Source/WebKit/chromium/public/WebInputEvent.h:371
> +    float unacceleratedDeltaX;
> +    float unacceleratedDeltaY;

Should we add some comments explaining the difference between unacceleratedDeltaX and deltaX?  Does deltaX/unacceleratedDeltaX always equal deltaY/unacceleratedDeltaY?  If so, should we ASSERT that somewhere?  Should we just supply the ratio instead?

[Sadrul Habib Chowdhury]

Created attachment 187993 [details]
Patch

[Sadrul Habib Chowdhury]

Comment on attachment 187932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187932&action=review

>> Source/WebKit/chromium/public/WebInputEvent.h:371
>> +    float unacceleratedDeltaY;
> 
> Should we add some comments explaining the difference between unacceleratedDeltaX and deltaX?  Does deltaX/unacceleratedDeltaX always equal deltaY/unacceleratedDeltaY?  If so, should we ASSERT that somewhere?  Should we just supply the ratio instead?

Using the ratio sounds much better! Thanks! I have changed to use that.

[Adam Barth]

Does the ratio apply to the wheel ticks as well?

[Sadrul Habib Chowdhury]

(In reply to comment #9)
> Does the ratio apply to the wheel ticks as well?

Indeed it does. (wheelTicksX/Y are often computed from deltaX/Y)

[WebKit Review Bot]

Comment on attachment 187993 [details]
Patch

Clearing flags on attachment: 187993

Committed r142752: <http://trac.webkit.org/changeset/142752>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.