Summary: | [chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sadrul Habib Chowdhury <sadrul> | ||||||||
Component: | New Bugs | Assignee: | Sadrul Habib Chowdhury <sadrul> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, dglazkov, eric, fishd, jamesr, tdanderson, tkent+wkapi, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Sadrul Habib Chowdhury
2013-02-12 13:59:27 PST
Created attachment 187929 [details]
Patch
Comment on attachment 187929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187929&action=review > Source/WebKit/chromium/ChangeLog:6 > + Mousewheel events generated by trackpad can have accelrated deltas (e.g. when doing typo: accelrated Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Created attachment 187932 [details]
Patch
Comment on attachment 187929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187929&action=review >> Source/WebKit/chromium/ChangeLog:6 >> + Mousewheel events generated by trackpad can have accelrated deltas (e.g. when doing > > typo: accelrated Whoops. Fixed. Comment on attachment 187932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187932&action=review > Source/WebKit/chromium/public/WebInputEvent.h:371 > + float unacceleratedDeltaX; > + float unacceleratedDeltaY; Should we add some comments explaining the difference between unacceleratedDeltaX and deltaX? Does deltaX/unacceleratedDeltaX always equal deltaY/unacceleratedDeltaY? If so, should we ASSERT that somewhere? Should we just supply the ratio instead? Created attachment 187993 [details]
Patch
Comment on attachment 187932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187932&action=review >> Source/WebKit/chromium/public/WebInputEvent.h:371 >> + float unacceleratedDeltaY; > > Should we add some comments explaining the difference between unacceleratedDeltaX and deltaX? Does deltaX/unacceleratedDeltaX always equal deltaY/unacceleratedDeltaY? If so, should we ASSERT that somewhere? Should we just supply the ratio instead? Using the ratio sounds much better! Thanks! I have changed to use that. Does the ratio apply to the wheel ticks as well? (In reply to comment #9) > Does the ratio apply to the wheel ticks as well? Indeed it does. (wheelTicksX/Y are often computed from deltaX/Y) Comment on attachment 187993 [details] Patch Clearing flags on attachment: 187993 Committed r142752: <http://trac.webkit.org/changeset/142752> All reviewed patches have been landed. Closing bug. |