Bug 109599

Summary: Synchronize setting of panner node model and processing
Product: WebKit Reporter: Raymond Toy <rtoy>
Component: New BugsAssignee: Raymond Toy <rtoy>
Status: RESOLVED FIXED    
Severity: Normal CC: crogers, eric.carlson, feature-media-reviews, levin+threading, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Raymond Toy 2013-02-12 11:01:51 PST
Synchronize setting of panner node model and processing
Comment 1 Raymond Toy 2013-02-12 11:18:02 PST
Created attachment 187903 [details]
Patch
Comment 2 Chris Rogers 2013-02-12 13:25:15 PST
Comment on attachment 187903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187903&action=review

some nits - looks good overall

> Source/WebCore/Modules/webaudio/PannerNode.cpp:115
> +    }

you need an else clause similar (but not identical) to AudioBufferSourceNode:

    } else {
        // Too bad - the tryLock() failed.  We must be in the middle of changing buffers and were already outputting silence anyway.
        outputBus->zero();
    }

> Source/WebCore/Modules/webaudio/PannerNode.cpp:192
> +            // This synchronizes with process()

nit: period at end of sentence

> Source/WebCore/Modules/webaudio/PannerNode.h:158
> +    // Synchronize process() and setPanningModel() which can change the panner

nit: period at end of sentence
Comment 3 Raymond Toy 2013-02-12 13:36:41 PST
Created attachment 187922 [details]
Patch
Comment 4 Raymond Toy 2013-02-12 13:37:56 PST
(In reply to comment #2)
> (From update of attachment 187903 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187903&action=review
> 
> some nits - looks good overall
> 
> > Source/WebCore/Modules/webaudio/PannerNode.cpp:115
> > +    }
> 
> you need an else clause similar (but not identical) to AudioBufferSourceNode:
> 
>     } else {
>         // Too bad - the tryLock() failed.  We must be in the middle of changing buffers and were already outputting silence anyway.
>         outputBus->zero();
>     }
> 
> > Source/WebCore/Modules/webaudio/PannerNode.cpp:192
> > +            // This synchronizes with process()
> 
> nit: period at end of sentence
> 
> > Source/WebCore/Modules/webaudio/PannerNode.h:158
> > +    // Synchronize process() and setPanningModel() which can change the panner
> 
> nit: period at end of sentence

Fixed according to your comments.
Comment 5 Chris Rogers 2013-02-12 14:35:55 PST
Comment on attachment 187922 [details]
Patch

thanks!
Comment 6 WebKit Review Bot 2013-02-12 14:44:04 PST
Comment on attachment 187922 [details]
Patch

Rejecting attachment 187922 [details] from commit-queue.

rtoy@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 7 WebKit Review Bot 2013-02-12 16:12:23 PST
Comment on attachment 187922 [details]
Patch

Clearing flags on attachment: 187922

Committed r142687: <http://trac.webkit.org/changeset/142687>
Comment 8 WebKit Review Bot 2013-02-12 16:12:27 PST
All reviewed patches have been landed.  Closing bug.