Bug 109585

Summary: Web Inspector: highlight undefined word in JavaScript
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
gray highlight of "undefined" global object value property.
none
Patch none

Andrey Lushnikov
Reported 2013-02-12 07:37:26 PST
Highlight "undefined" javascript word (without quotes) in DTE
Attachments
Patch (11.45 KB, patch)
2013-02-12 07:50 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
gray highlight of "undefined" global object value property. (6.18 KB, image/png)
2013-02-19 04:36 PST, Andrey Lushnikov 		no flags
Details
Patch (8.44 KB, patch)
2013-02-19 04:38 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-02-12 07:50:43 PST
Created attachment 187867 [details] Patch
Vsevolod Vlasov
Comment 2 2013-02-12 23:56:05 PST
Comment on attachment 187867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187867&action=review > Source/WebCore/inspector/front-end/SourceJavaScriptTokenizer.re2js:176 > + if (token === "undefined") I would rather add something like WebInspector.SourceJavaScriptTokenizer.GlobalObjectProperties and put NaN, Object, String, Number there as well as undefined.
Andrey Lushnikov
Comment 3 2013-02-13 00:12:36 PST
Comment on attachment 187867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187867&action=review >> Source/WebCore/inspector/front-end/SourceJavaScriptTokenizer.re2js:176 >> + if (token === "undefined") > > I would rather add something like WebInspector.SourceJavaScriptTokenizer.GlobalObjectProperties and put NaN, Object, String, Number there as well as undefined. Sounds reasonable
Andrey Lushnikov
Comment 4 2013-02-19 04:36:23 PST
Created attachment 189056 [details] gray highlight of "undefined" global object value property.
Andrey Lushnikov
Comment 5 2013-02-19 04:38:10 PST
Created attachment 189057 [details] Patch
WebKit Review Bot
Comment 6 2013-02-20 01:46:20 PST
Comment on attachment 189057 [details] Patch Clearing flags on attachment: 189057 Committed r143440: <http://trac.webkit.org/changeset/143440>
WebKit Review Bot
Comment 7 2013-02-20 01:46:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.