Bug 109575

Summary:

[chromium] move text dump generation to TestRunner library

Product:

WebKit

Reporter:

jochen

Component:

New Bugs

Assignee:

jochen

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, alecflett, dglazkov, fishd, jamesr, peter+ews, tkent+wkapi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

109622

Bug Blocks:

108469

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

jochen

Reported 2013-02-12 05:37:41 PST

[chromium] move text dump generation to TestRunner library

Attachments
Patch (33.99 KB, patch) 2013-02-12 05:38 PST, jochen	no flags	Details Formatted Diff Diff
Patch (34.16 KB, patch) 2013-02-12 05:49 PST, jochen	no flags	Details Formatted Diff Diff
Patch (34.27 KB, patch) 2013-02-12 06:36 PST, jochen	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

jochen

Comment 1 2013-02-12 05:38:07 PST

Created attachment 187843 [details] Patch

WebKit Review Bot

Comment 2 2013-02-12 05:41:26 PST

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

WebKit Review Bot

Comment 3 2013-02-12 05:41:43 PST

Attachment 187843 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/DumpRenderTree.gypi', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp', u'Tools/DumpRenderTree/chromium/TestShell.cpp', u'Tools/DumpRenderTree/chromium/TestShell.h', u'Tools/DumpRenderTree/chromium/WebViewHost.cpp', u'Tools/DumpRenderTree/chromium/WebViewHost.h']" exit_code: 1 Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:338: Use equivelent function in <wtf/ASCIICType.h> instead of the tolower() function. [runtime/ctype_function] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

jochen

Comment 4 2013-02-12 05:42:35 PST

(In reply to comment #3) > Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:338: Use equivelent function in <wtf/ASCIICType.h> instead of the tolower() function. [runtime/ctype_function] [4] I copied the code from TestShell (and I can't use wtf from TestRunner anyway)

Peter Beverloo (cr-android ews)

Comment 5 2013-02-12 05:47:49 PST

Comment on attachment 187843 [details] Patch Attachment 187843 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16454236

jochen

Comment 6 2013-02-12 05:49:22 PST

Created attachment 187846 [details] Patch

WebKit Review Bot

Comment 7 2013-02-12 05:52:21 PST

Attachment 187846 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/DumpRenderTree.gypi', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp', u'Tools/DumpRenderTree/chromium/TestShell.cpp', u'Tools/DumpRenderTree/chromium/TestShell.h', u'Tools/DumpRenderTree/chromium/WebViewHost.cpp', u'Tools/DumpRenderTree/chromium/WebViewHost.h']" exit_code: 1 Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:339: Use equivelent function in <wtf/ASCIICType.h> instead of the tolower() function. [runtime/ctype_function] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 8 2013-02-12 06:31:44 PST

Comment on attachment 187846 [details] Patch Attachment 187846 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16483199 New failing tests: fast/overflow/scrollRevealButton.html

jochen

Comment 9 2013-02-12 06:36:34 PST

Created attachment 187857 [details] Patch

WebKit Review Bot

Comment 10 2013-02-12 06:41:53 PST

Attachment 187857 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/DumpRenderTree.gypi', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp', u'Tools/DumpRenderTree/chromium/TestShell.cpp', u'Tools/DumpRenderTree/chromium/TestShell.h', u'Tools/DumpRenderTree/chromium/WebViewHost.cpp', u'Tools/DumpRenderTree/chromium/WebViewHost.h']" exit_code: 1 Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:339: Use equivelent function in <wtf/ASCIICType.h> instead of the tolower() function. [runtime/ctype_function] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

jochen

Comment 11 2013-02-12 10:52:21 PST

Comment on attachment 187857 [details] Patch Clearing flags on attachment: 187857 Committed r142643: <http://trac.webkit.org/changeset/142643>

jochen

Comment 12 2013-02-12 10:52:25 PST

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 13 2013-02-12 15:27:59 PST

Re-opened since this is blocked by bug 109622

Alec Flett

Comment 14 2013-02-12 15:47:03 PST

breakage fixed in 109623

Note You need to log in before you can comment on or make changes to this bug.