Bug 109543
Summary: | Chromium/Win vs2012: compile failed Source/WebKit/chromium/tests/PrerenderingTest.cpp | ||
---|---|---|---|
Product: | WebKit | Reporter: | Fumitoshi Ukai <ukai> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED WONTFIX | ||
Severity: | Normal | CC: | fishd, jamesr, schenney, scottmg |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Fumitoshi Ukai
It started failing compile Source/WebKit/chromium/tests/PrerenderingTest.cpp on chromium vs2012 since
http://chromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Win%20VS2012/builds/4865
webkit roll 142403:142426, so probably http://trac.webkit.org/changeset/142422 is culprit.
FAILED: ninja -t msvc -o obj\third_party\webkit\source\webkit\chromium\tests\webkit.prerenderingtest.obj -e environment.x86 -- cl.exe /nologo /showIncludes /FC @obj\third_party\webkit\source\webkit\chromium\tests\webkit.prerenderingtest.obj.rsp /c ..\..\third_party\WebKit\Source\WebKit\chromium\tests\PrerenderingTest.cpp /Foobj\third_party\webkit\source\webkit\chromium\tests\webkit.prerenderingtest.obj /Fdobj\third_party\WebKit\Source\WebKit\chromium\webkit.pdb
e:\b\build\slave\chromium_win_vs2012\build\src\third_party\webkit\source\webkit\chromium\tests\prerenderingtest.cpp(134) : error C2039: 'bind1st' : is not a member of 'std'
e:\b\build\slave\chromium_win_vs2012\build\src\third_party\webkit\source\webkit\chromium\tests\prerenderingtest.cpp(134) : error C3861: 'bind1st': identifier not found
e:\b\build\slave\chromium_win_vs2012\build\src\third_party\webkit\source\webkit\chromium\tests\prerenderingtest.cpp(139) : error C2039: 'bind1st' : is not a member of 'std'
e:\b\build\slave\chromium_win_vs2012\build\src\third_party\webkit\source\webkit\chromium\tests\prerenderingtest.cpp(139) : error C3861: 'bind1st': identifier not found
e:\b\build\slave\chromium_win_vs2012\build\src\third_party\webkit\source\webkit\chromium\tests\prerenderingtest.cpp(144) : error C2039: 'bind1st' : is not a member of 'std'
e:\b\build\slave\chromium_win_vs2012\build\src\third_party\webkit\source\webkit\chromium\tests\prerenderingtest.cpp(144) : error C3861: 'bind1st': identifier not found
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
James Robinson
(In reply to comment #0)
> It started failing compile Source/WebKit/chromium/tests/PrerenderingTest.cpp on chromium vs2012 since
> http://chromegw.corp.google.com....
This is not a publically accessible link. Please link to the public version of buildbot URL logs.
>
> FAILED: ninja -t msvc -o obj\third_party\webkit\source\webkit\chromium\tests\webkit.prerenderingtest.obj -e environment.x86 -- cl.exe /nologo /showIncludes /FC @obj\third_party\webkit\source\webkit\chromium\tests\webkit.prerenderingtest.obj.rsp /c ..\..\third_party\WebKit\Source\WebKit\chromium\tests\PrerenderingTest.cpp /Foobj\third_party\webkit\source\webkit\chromium\tests\webkit.prerenderingtest.obj /Fdobj\third_party\WebKit\Source\WebKit\chromium\webkit.pdb
> e:\b\build\slave\chromium_win_vs2012\build\src\third_party\webkit\source\webkit\chromium\tests\prerenderingtest.cpp(134) : error C2039: 'bind1st' : is not a member of 'std'
>
> e:\b\build\slave\chromium_win_vs2012\build\src\third_party\webkit\source\webkit\chromium\tests\prerenderingtest.cpp(134) : error C3861: 'bind1st': identifier not found
>
> e:\b\build\slave\chromium_win_vs2012\build\src\third_party\webkit\source\webkit\chromium\tests\prerenderingtest.cpp(139) : error C2039: 'bind1st' : is not a member of 'std'
>
> e:\b\build\slave\chromium_win_vs2012\build\src\third_party\webkit\source\webkit\chromium\tests\prerenderingtest.cpp(139) : error C3861: 'bind1st': identifier not found
>
> e:\b\build\slave\chromium_win_vs2012\build\src\third_party\webkit\source\webkit\chromium\tests\prerenderingtest.cpp(144) : error C2039: 'bind1st' : is not a member of 'std'
>
> e:\b\build\slave\chromium_win_vs2012\build\src\third_party\webkit\source\webkit\chromium\tests\prerenderingtest.cpp(144) : error C3861: 'bind1st': identifier not found
Previously this test was not compiled in for component builds, but it was for static. Do you know if there is a static build VS2012 bot?
Fumitoshi Ukai
sorry, I think this is the public link
http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20VS2012/builds/4865
http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20VS2012/builds/4864
was ok
James Robinson
(In reply to comment #2)
> sorry, I think this is the public link
> http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20VS2012/builds/4865
>
> http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20VS2012/builds/4864
> was ok
Yes, but that doesn't really tell us a lot since this bot is component and pre-r142422 this target didn't compile at all on component builds (it was excluded in the gyp files). Are there any bots that are release mode / non-component build with VS2012? That would tell us if this file ever compiled on VS2012.
It's possible we just need more includes - maybe a #include <functional> would do the trick.