| Summary: | [Cairo] Anti-aliasing should not be always disabled for lines | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> | ||||||||||||||||
| Component: | WebCore Misc. | Assignee: | Viatcheslav Ostapenko <ostap73> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | commit-queue, d-r, gyuyoung.kim, igor.oliveira, laszlo.gombos, mrobinson, rakuco, treatassignmenthelp, webkit.review.bot | ||||||||||||||||
| Priority: | P2 | ||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Laszlo Gombos
2013-02-11 18:47:35 PST
Created attachment 194547 [details]
Unscaled page sample with underlines.
Created attachment 194550 [details]
Scaled page sample.
Notice, that "Global Attributes in HTML" underline is too bold and "Event Attribute in HTML" underline disappeared.
Created attachment 194693 [details]
Patch
Comment on attachment 194693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194693&action=review > LayoutTests/ChangeLog:10 > + * fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt: Added. What platform is this result for? I imagine that few platforms will be able to share this result. (In reply to comment #4) > (From update of attachment 194693 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=194693&action=review > > > LayoutTests/ChangeLog:10 > > + * fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt: Added. > > What platform is this result for? I imagine that few platforms will be able to share this result. IMHO, GTK should be able to share. And other cairo platforms. Chromium has somewhat strange code there and still has a problem similar to what EFL has without patch (like on scaled page sample). (In reply to comment #5) > > What platform is this result for? I imagine that few platforms will be able to share this result. > > IMHO, GTK should be able to share. And other cairo platforms. Chromium has somewhat strange code there and still has a problem similar to what EFL has without patch (like on scaled page sample). Sorry my comment was pretty unclear. The result in your patch is placed in the platform-independent directory, but it's almost certain that Mac, Qt, Chromium and all other ports will required separate baselines. (In reply to comment #6) > (In reply to comment #5) > > > > What platform is this result for? I imagine that few platforms will be able to share this result. > > > > IMHO, GTK should be able to share. And other cairo platforms. Chromium has somewhat strange code there and still has a problem similar to what EFL has > without patch (like on scaled page sample). > > Sorry my comment was pretty unclear. The result in your patch is placed in the platform-independent directory, but it's almost certain that Mac, Qt, Chromium and all other ports will required separate baselines. Test results that are in common directory are generated for chromium build. Should I move it to chromium platform results? (In reply to comment #7) > Test results that are in common directory are generated for chromium build. Should I move it to chromium platform results? Sorry for the late reply. I think these need to be moved to Chromium specific directories. I'm not sure if they need to be specific to Chromium linux or all Chromium ports. Created attachment 200444 [details]
Patch for test results
Created attachment 200447 [details]
Patch for test results
Created attachment 200451 [details]
Failing test to get pixel test results from EWS. Not for review!!!
Created attachment 200469 [details]
Patch for landing
Comment on attachment 200469 [details] Patch for landing Clearing flags on attachment: 200469 Committed r149540: <http://trac.webkit.org/changeset/149540> All reviewed patches have been landed. Closing bug. |