Bug 109511

Summary:

[JSC] DFG might force a local to be double even if we store non-numeric values into it

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Alexey Shvayka <ashvayka>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ashvayka, barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
test case	none

Filip Pizlo

Reported 2013-02-11 16:12:48 PST

This appears to happen due to argument positions, and the fact that tallyVotesForShouldUseDoubleFormat() doesn't set NotUsingDoubleFormat. A great example of this is the test case for https://bugs.webkit.org/show_bug.cgi?id=109491

Attachments
test case (492 bytes, text/plain) 2014-06-10 14:02 PDT, Filip Pizlo	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2014-06-10 14:02:06 PDT

Created attachment 232813 [details] test case

Alexey Shvayka

Comment 2 2023-10-12 14:08:30 PDT

<rdar://116397731>

Alexey Shvayka

Comment 3 2023-12-17 12:27:37 PST

Fixed in https://github.com/WebKit/WebKit/commit/bf2f05e02c8a12f6b716ea8bc21e62852d8493ac.

Note You need to log in before you can comment on or make changes to this bug.