Bug 109507

Summary:

Rebaseline text output for opaque GraphicsLayers

Product:

WebKit

Reporter:

Alok Priyadarshi <alokp>

Component:

Layout and Rendering

Assignee:

Alok Priyadarshi <alokp>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, gyuyoung.kim, jamesr, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

70634, 112062

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-05 for chromium-linux-x86_64	none

Description Alok Priyadarshi 2013-02-11 15:37:59 PST

After the patch for https://bugs.webkit.org/show_bug.cgi?id=70634 lands, we need to rebaseline the following tests:

compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
compositing/layer-creation/fixed-position-out-of-view-scaled.html
platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled.html

Comment 1 Alok Priyadarshi 2013-03-05 12:43:07 PST

Created attachment 191538 [details]
Patch

Comment 2 Alok Priyadarshi 2013-03-05 14:27:11 PST

Committed r144818: <http://trac.webkit.org/changeset/144818>

Comment 3 Alok Priyadarshi 2013-03-11 12:55:05 PDT

Need to rollout because the patch for 70634 needs to rollout.

Comment 4 Alok Priyadarshi 2013-03-26 12:12:46 PDT

Created attachment 195135 [details]
Patch

Comment 5 Alok Priyadarshi 2013-03-26 12:15:25 PDT

Rebaseline also includes changes due to drawsContent flag.
The rtl-iframe tests have other failures that this patch avoids rebaselining.

Comment 6 James Robinson 2013-03-26 12:31:29 PDT

Just land these, there's no way to review.

Comment 7 WebKit Review Bot 2013-03-26 13:01:46 PDT

Comment on attachment 195135 [details]
Patch

Attachment 195135 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17147884

New failing tests:
compositing/iframes/scrolling-iframe.html
platform/chromium/virtual/softwarecompositing/iframes/scrolling-iframe.html

Comment 8 WebKit Review Bot 2013-03-26 13:01:50 PDT

Created attachment 195148 [details]
Archive of layout-test-results from gce-cr-linux-05 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

Comment 9 Alok Priyadarshi 2013-03-26 13:36:20 PDT

Committed r146925: <http://trac.webkit.org/changeset/146925>

Comment 10 Levi Weintraub 2013-04-08 10:53:24 PDT

Comment on attachment 195135 [details]
Patch

Clearing flags