Summary: | DFG LogicalNot/Branch peephole removal and inversion ignores the possibility of things exiting | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough, buildbot, dglazkov, ggaren, mark.lam, mhahnenberg, msaboff, oliver, rniwa, sam, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2013-02-11 14:23:28 PST
Created attachment 188019 [details]
the wrong way
I started by assuming that we should just introduce CompareNotEq and friends. I think this is not a good idea.
I will do it a better way.
Created attachment 188024 [details]
another wrong way
Created attachment 188027 [details]
the patch
I went for the brute force way. Still need to test if this is OK for performance...
I'm also still running tests, will have expectations file soon.
Comment on attachment 188027 [details] the patch Attachment 188027 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16530028 New failing tests: fast/js/dfg-branch-logical-not-peephole-around-osr-exit.html Comment on attachment 188027 [details] the patch Attachment 188027 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16454796 New failing tests: fast/js/dfg-branch-logical-not-peephole-around-osr-exit.html Comment on attachment 188027 [details]
the patch
r=me with test expectations.
Landed in http://trac.webkit.org/changeset/142779 |