Bug 109476

Summary: REGRESSION(r136967): Combination of float and clear yields to bad layout
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Robert Hogan <robert>
Severity: Normal CC: eric, hyatt, leviw, ojan.autocc, robert, webkit.review.bot
Priority: P1 Keywords: HasReduction, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://reallysimpleworks.com/experiments/float-bug-test.html
Description Flags
Patch none

Description Julien Chaffraix 2013-02-11 13:13:35 PST
This is a confirmed regression from http://trac.webkit.org/changeset/136967.

The floats are aligned in Firefox and Opera and before the change. Not sure if it has any relation with the bug but it seems that there is some overlap of the background box.
Comment 1 Robert Hogan 2013-02-11 14:02:54 PST
Created attachment 187662 [details]
Comment 2 Levi Weintraub 2013-02-11 17:59:35 PST
Comment on attachment 187662 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=187662&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2284
>              // The top margin edge of a self-collapsing block that clears a float intrudes up into it by the height of the margin,
>              // so in order to place this child float at the top content edge of the self-collapsing block add the margin back in before placement.

It may be worthwhile updating the comment since it's here. "in order to place the first child"
Comment 3 Robert Hogan 2013-02-12 12:23:51 PST
Created attachment 187911 [details]
Comment 4 WebKit Review Bot 2013-02-12 13:07:45 PST
Comment on attachment 187911 [details]

Clearing flags on attachment: 187911

Committed r142659: <http://trac.webkit.org/changeset/142659>
Comment 5 WebKit Review Bot 2013-02-12 13:07:49 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Julien Chaffraix 2013-02-12 14:27:11 PST
For the next time, it would have been nice to update the bug title to something precise. My description was inaccurate as I didn't know what was wrong.
Comment 7 Robert Hogan 2013-02-21 11:14:57 PST
*** Bug 110274 has been marked as a duplicate of this bug. ***