| Summary: | REGRESSION(r136967): Combination of float and clear yields to bad layout | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> | ||||||
| Component: | Layout and Rendering | Assignee: | Robert Hogan <robert> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric, hyatt, leviw, ojan.autocc, robert, webkit.review.bot | ||||||
| Priority: | P1 | Keywords: | HasReduction, Regression | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| URL: | http://reallysimpleworks.com/experiments/float-bug-test.html | ||||||||
| Attachments: |
|
||||||||
|
Description
Julien Chaffraix
2013-02-11 13:13:35 PST
Created attachment 187662 [details]
Patch
Comment on attachment 187662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187662&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:2284 > // The top margin edge of a self-collapsing block that clears a float intrudes up into it by the height of the margin, > // so in order to place this child float at the top content edge of the self-collapsing block add the margin back in before placement. It may be worthwhile updating the comment since it's here. "in order to place the first child" Created attachment 187911 [details]
Patch
Comment on attachment 187911 [details] Patch Clearing flags on attachment: 187911 Committed r142659: <http://trac.webkit.org/changeset/142659> All reviewed patches have been landed. Closing bug. For the next time, it would have been nice to update the bug title to something precise. My description was inaccurate as I didn't know what was wrong. *** Bug 110274 has been marked as a duplicate of this bug. *** |