Bug 109476

Summary: REGRESSION(r136967): Combination of float and clear yields to bad layout
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Robert Hogan <robert>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hyatt, leviw, ojan.autocc, robert, webkit.review.bot
Priority: P1 Keywords: HasReduction, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://reallysimpleworks.com/experiments/float-bug-test.html
Attachments:
Description Flags
Patch
none
Patch none

Julien Chaffraix
Reported 2013-02-11 13:13:35 PST
This is a confirmed regression from http://trac.webkit.org/changeset/136967. The floats are aligned in Firefox and Opera and before the change. Not sure if it has any relation with the bug but it seems that there is some overlap of the background box.
Attachments
Patch (5.27 KB, patch)
2013-02-11 14:02 PST, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Patch (5.44 KB, patch)
2013-02-12 12:23 PST, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2013-02-11 14:02:54 PST
Created attachment 187662 [details] Patch
Levi Weintraub
Comment 2 2013-02-11 17:59:35 PST
Comment on attachment 187662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187662&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:2284 > // The top margin edge of a self-collapsing block that clears a float intrudes up into it by the height of the margin, > // so in order to place this child float at the top content edge of the self-collapsing block add the margin back in before placement. It may be worthwhile updating the comment since it's here. "in order to place the first child"
Robert Hogan
Comment 3 2013-02-12 12:23:51 PST
Created attachment 187911 [details] Patch
WebKit Review Bot
Comment 4 2013-02-12 13:07:45 PST
Comment on attachment 187911 [details] Patch Clearing flags on attachment: 187911 Committed r142659: <http://trac.webkit.org/changeset/142659>
WebKit Review Bot
Comment 5 2013-02-12 13:07:49 PST
All reviewed patches have been landed. Closing bug.
Julien Chaffraix
Comment 6 2013-02-12 14:27:11 PST
For the next time, it would have been nice to update the bug title to something precise. My description was inaccurate as I didn't know what was wrong.
Robert Hogan
Comment 7 2013-02-21 11:14:57 PST
*** Bug 110274 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.