Bug 109475

Summary:

[GTK] Enable CSS image-set support in development builds

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, dbates, mrobinson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

109587

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Zan Dobersek 2013-02-11 13:11:53 PST

[GTK] Enable CSS image-set support in development builds

Comment 1 Zan Dobersek 2013-02-11 13:15:45 PST

Created attachment 187648 [details]
Patch

Comment 2 Zan Dobersek 2013-02-12 05:27:26 PST

Comment on attachment 187648 [details]
Patch

Clearing flags on attachment: 187648

Committed r142606: <http://trac.webkit.org/changeset/142606>

Comment 3 Zan Dobersek 2013-02-12 05:27:30 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Chris Dumez 2013-02-12 06:41:47 PST

It seems this patch somehow disabled CSS_IMAGE_SET for EFL port?
It brought a few failures on our bots:
http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r142607%20(9378)/results.html

Comment 5 Chris Dumez 2013-02-12 06:43:28 PST

Comment on attachment 187648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187648&action=review

> Tools/Scripts/webkitperl/FeatureList.pm:211
> +      define => "ENABLE_CSS_IMAGE_SET", default => isGtk(), value => \$cssImageSetSupport },

So It seems we need a " || isEfl()" here? Some other ports probably have CSS_IMAGE_SET enabled as well (mac, chormium for e.g.).

Comment 6 Zan Dobersek 2013-02-12 06:58:09 PST

(In reply to comment #5)
> (From update of attachment 187648 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187648&action=review
> 
> > Tools/Scripts/webkitperl/FeatureList.pm:211
> > +      define => "ENABLE_CSS_IMAGE_SET", default => isGtk(), value => \$cssImageSetSupport },
> 
> So It seems we need a " || isEfl()" here? Some other ports probably have CSS_IMAGE_SET enabled as well (mac, chormium for e.g.).

Did that in r142617.
http://trac.webkit.org/changeset/142617

As for other ports, the Chromium port manages feature enabling in Source/WebKit/chromium/features.gypi independently from FeatureList.pm while the Mac port enables this feature by defining the macro in Platform.h, probably because it's also defined for the iOS platform. I'm not really comfortable changing that but it still seems to work (i.e. the feature is enabled at compile-time) despite the not enabling the feature in FeatureList.pm.

Comment 7 Chris Dumez 2013-02-12 06:59:07 PST

(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 187648 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=187648&action=review
> > 
> > > Tools/Scripts/webkitperl/FeatureList.pm:211
> > > +      define => "ENABLE_CSS_IMAGE_SET", default => isGtk(), value => \$cssImageSetSupport },
> > 
> > So It seems we need a " || isEfl()" here? Some other ports probably have CSS_IMAGE_SET enabled as well (mac, chormium for e.g.).
> 
> Did that in r142617.
> http://trac.webkit.org/changeset/142617
> 
> As for other ports, the Chromium port manages feature enabling in Source/WebKit/chromium/features.gypi independently from FeatureList.pm while the Mac port enables this feature by defining the macro in Platform.h, probably because it's also defined for the iOS platform. I'm not really comfortable changing that but it still seems to work (i.e. the feature is enabled at compile-time) despite the not enabling the feature in FeatureList.pm.

Sounds good to me. Thank you for the quick fix.