Bug 10946

Summary: new marker code draws end-marker in wrong place
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
test case, should show 100x100 green block when correct
none
First attempt eric: review+

Eric Seidel (no email)
Reported 2006-09-20 02:56:47 PDT
new marker code draws end-marker in wrong place I caused a regression for marker drawing with my new marker code. I've attached a reduction. Should be simple to fix.
Attachments
test case, should show 100x100 green block when correct (529 bytes, image/svg+xml)
2006-09-20 02:57 PDT, Eric Seidel (no email) 		no flags
Details
First attempt (23.81 KB, patch)
2006-09-20 13:56 PDT, Rob Buis 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2006-09-20 02:57:23 PDT
Created attachment 10664 [details] test case, should show 100x100 green block when correct
Rob Buis
Comment 2 2006-09-20 10:31:51 PDT
(In reply to comment #1) > Created an attachment (id=10664) [edit] > test case, should show 100x100 green block when correct Just so that nobody wastes time on fixing this, I have a working patch. I'll upload it soon. Cheers, Rob.
Rob Buis
Comment 3 2006-09-20 13:56:54 PDT
Created attachment 10673 [details] First attempt This fixes the problem, I think this problem was always there, but Erics clipping fixes probably really showed it. Cheers, Rob.
Eric Seidel (no email)
Comment 4 2006-09-20 15:14:28 PDT
Comment on attachment 10673 [details] First attempt This looks like a great fix. I'm not quite sure why we need to store both origin as well as subpathStart, so perhaps you can explain that to me over IRC before landing. Overall this looks fabulous though. r=me.
Rob Buis
Comment 5 2006-09-21 00:24:31 PDT
(In reply to comment #4) > (From update of attachment 10673 [details] [edit]) > This looks like a great fix. I'm not quite sure why we need to store both > origin as well as subpathStart, so perhaps you can explain that to me over IRC > before landing. Overall this looks fabulous though. r=me. > That will be hard, since you are not on IRC :) Anyway origin seems different, it seems to be more like "current point" and changes for each path iteration. So I think subpathStart is really needed. Cheers, Rob.
Rob Buis
Comment 6 2006-09-21 02:23:17 PDT
Landed in r16494.
Note You need to log in before you can comment on or make changes to this bug.