Summary: | [WK2][EFL][WTR] Regression(r141836): WTR crashes on exit | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||||
Component: | WebKit EFL | Assignee: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, benjamin, cdumez, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mikhail Pozdnyakov
2013-02-11 09:33:33 PST
Ahh.. several different problem lead to exact same crash..!! (at the same time ) Created attachment 187615 [details]
patch
Kill two crashes with one patch
Comment on attachment 187615 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=187615&action=review > Source/WebKit2/ChangeLog:8 > + WebView dtor now consideres the situation if its WebPageProxy dtor->destructor. consideres->considers > Source/WebKit2/UIProcess/efl/WebView.cpp:54 > + // Can be closed already from outside the class. This comments does not add enough information to be useful. You should either remove the comment, or full explain the events that leads to such situation. > Tools/WebKitTestRunner/efl/main.cpp:52 > + // Prefer the not installed web and plugin processes. What?? Comment on attachment 187615 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=187615&action=review >> Source/WebKit2/UIProcess/efl/WebView.cpp:54 >> + // Can be closed already from outside the class. > > This comments does not add enough information to be useful. > You should either remove the comment, or full explain the events that leads to such situation. ok. >> Tools/WebKitTestRunner/efl/main.cpp:52 >> + // Prefer the not installed web and plugin processes. > > What?? that's not my comment, changing/removing it wasn't within scope of this patch :) Thanks for review! Created attachment 187804 [details]
patch v2
Took comments from Benjamin into consideration.
Comment on attachment 187804 [details] patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=187804&action=review > Tools/WebKitTestRunner/efl/main.cpp:49 > + // Test controller has own ptr containing WebView and Webview must be deleted Spelling Webview* -> WebView Created attachment 188062 [details]
patch v3
Fixed misspelling in the comment.
Comment on attachment 188062 [details] patch v3 Clearing flags on attachment: 188062 Committed r142748: <http://trac.webkit.org/changeset/142748> All reviewed patches have been landed. Closing bug. |