Bug 109453

Summary: Web Inspector: provide basic console.table implementation (no [,columns] support)
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, graouts, joepeck, keishi, loislo, mkwst+watchlist, ojan.autocc, pfeldman, pmuellr, syoichi, timothy, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Screenshot with patch applied
none
Patch
none
Patch
none
[IMAGE] Screenshot with beverloo applied
none
[wip]
none
Patch none

Description Pavel Feldman 2013-02-11 09:17:40 PST
This change adds support for console.table command supported in Firebug. Here is the syntax:

    console.table([[1,2,3], [2,3,4]]);
    console.table([{a:1, b:2, c:3}, {a:"foo", b:false, c:undefined}]);

Screenshot to follow.
Comment 1 Pavel Feldman 2013-02-11 09:21:54 PST
Created attachment 187597 [details]
[IMAGE] Screenshot with patch applied
Comment 2 Pavel Feldman 2013-02-11 10:16:14 PST
Created attachment 187611 [details]
Patch
Comment 3 Andrey Adaikin 2013-02-11 10:50:59 PST
Comment on attachment 187611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187611&action=review

> Source/WebCore/inspector/front-end/ConsoleMessage.js:86
> +            delete this._dataGrid;

this._dataGrid was never defined
Comment 4 Pavel Feldman 2013-02-12 06:08:15 PST
Created attachment 187850 [details]
Patch
Comment 5 Pavel Feldman 2013-02-12 06:09:04 PST
Created attachment 187851 [details]
[IMAGE] Screenshot with beverloo applied
Comment 6 Pavel Feldman 2013-02-17 02:56:19 PST
Created attachment 188762 [details]
[wip]
Comment 7 Pavel Feldman 2013-02-17 04:38:02 PST
Created attachment 188763 [details]
Patch
Comment 8 Vsevolod Vlasov 2013-02-18 02:25:19 PST
Comment on attachment 188763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188763&action=review

> Source/WebCore/inspector/InjectedScriptSource.js:151
> +        if (InjectedScriptHost.type(columns) == "array") {

===
Comment 9 WebKit Review Bot 2013-02-18 02:53:19 PST
Comment on attachment 188763 [details]
Patch

Clearing flags on attachment: 188763

Committed r143186: <http://trac.webkit.org/changeset/143186>
Comment 10 WebKit Review Bot 2013-02-18 02:53:23 PST
All reviewed patches have been landed.  Closing bug.