| Summary: | [chromium] move printPage() implementation to testRunner library | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||||
| Component: | New Bugs | Assignee: | jochen | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
jochen
2013-02-11 07:42:49 PST
Created attachment 187571 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 187571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187571&action=review > Tools/DumpRenderTree/chromium/WebViewHost.cpp:1336 > void WebViewHost::printPage(WebKit::WebFrame* frame) Should we add an ASSERT_NOT_REACHED here? Created attachment 187776 [details]
Patch for landing
(In reply to comment #3) > (From update of attachment 187571 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187571&action=review > > > Tools/DumpRenderTree/chromium/WebViewHost.cpp:1336 > > void WebViewHost::printPage(WebKit::WebFrame* frame) > > Should we add an ASSERT_NOT_REACHED here? I just deleted the empty method Comment on attachment 187776 [details] Patch for landing Clearing flags on attachment: 187776 Committed r142585: <http://trac.webkit.org/changeset/142585> All reviewed patches have been landed. Closing bug. |