Summary: | [WK2] Several Web inspector tests crash after r142160 | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED DUPLICATE | ||||||||||||
Severity: | Normal | CC: | andersca, ap, benjamin, d-r, kling, laszlo.gombos, lucas.de.marchi, naginenis, sam, tmpsantos | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 109409 | ||||||||||||
Bug Blocks: | 108785 | ||||||||||||
Attachments: |
|
Description
Chris Dumez
2013-02-11 00:53:04 PST
MiniBrowser is asserting with the same backtrace when the Web Process crashes. Looks like it's a regression from r142160. #0 0x00007fb8a0cb7c42 in WebKit::WebInspectorProxy::enableRemoteInspection (this=0x0) at WebKit/Source/WebKit2/UIProcess/WebInspectorProxy.cpp:285 285 if (!m_remoteInspectionPageId) (gdb) bt #0 0x00007fb8a0cb7c42 in WebKit::WebInspectorProxy::enableRemoteInspection (this=0x0) at WebKit/Source/WebKit2/UIProcess/WebInspectorProxy.cpp:285 #1 0x00007fb8a0cc9a5e in WebKit::WebPageProxy::initializeWebPage (this=0x18f0b10) at WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:439 #2 0x00007fb8a0cc96ca in WebKit::WebPageProxy::reattachToWebProcess (this=0x18f0b10) at WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:399 #3 0x00007fb8a0cca5ea in WebKit::WebPageProxy::loadAlternateHTMLString (this=0x18f0b10, htmlString="The web process has crashed.", baseURL="(null)", unreachableURL="file://WebKit/LayoutTests/inspector/styles/styles-include-host-rules-crash.html") at WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:617 #4 0x00007fb8a0d23402 in WKPageLoadAlternateHTMLString (pageRef=0x18f0b10, htmlStringRef=0x22808c0, baseURLRef=0x21fd890, unreachableURLRef=0x21fca50) at WebKit/Source/WebKit2/UIProcess/API/C/WKPage.cpp:78 #5 0x00007fb8a0e7efdd in ewk_view_html_string_load (ewkView=0x18e22e0, html=0x7fb8a10d826f "The web process has crashed.", baseUrl=0x0, unreachableUrl= 0x228b9a0 "file://WebKit/LayoutTests/inspector/styles/styles-include-host-rules-crash.html") at WebKit/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:280 #6 0x00007fb8a0e86653 in WebKit::PageClientBase::processDidCrash (this=0x18efb70) at WebKit/Source/WebKit2/UIProcess/efl/PageClientBase.cpp:137 #7 0x00007fb8a0cd68eb in WebKit::WebPageProxy::processDidCrash (this=0x18f0b10) at WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:3652 #8 0x00007fb8a0d0f4fc in WebKit::WebProcessProxy::didClose (this=0x18efbd0) at WebKit/Source/WebKit2/UIProcess/WebProcessProxy.cpp:402 #9 0x00007fb8a0befd39 in CoreIPC::Connection::dispatchConnectionDidClose (this=0x19f8340) at WebKit/Source/WebKit2/Platform/CoreIPC/Connection.cpp:660 #10 0x00007fb8a0bfef6a in WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator() (this=0x7fb834000980, c=0x19f8340) at WebKit/Source/WTF/wtf/Functional.h:218 Yes, babu is right. 1. WebPageProxy::processDidCrash() invalidates m_inspector 2. WebPageProxy::reattachToWebProcess() calls WebPageProxy::initializeWebPage() 3. WebPageProxy::initializeWebPage() uses m_inspector 4. WebPageProxy::reattachToWebProcess() initializes m_inspector I believe that in WebPageProxy::reattachToWebProcess(), m_inspector should be initialized *BEFORE* calling WebPageProxy::initializeWebPage() since WebPageProxy::initializeWebPage() requires m_inspector to be initialized. Created attachment 187531 [details] Patch This should fix the crash on UIProcess side. The crash on WebProcess side is tracked via Bug 109409. Created attachment 187532 [details]
Patch
Fix bug title.
Created attachment 187536 [details]
Patch
Created attachment 187537 [details]
Patch
Fix bug title.
Duplicate of bug 109305? That one also has a patch up for review. *** This bug has been marked as a duplicate of bug 109305 *** |