| Summary: | RenderStyle should use copy-on-write inheritance for NinePieceImage. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
| Component: | Layout and Rendering | Assignee: | Andreas Kling <kling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, eric, kling, koivisto, ojan.autocc, webkit.review.bot | ||||||
| Priority: | P2 | Keywords: | Performance | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andreas Kling
2013-02-09 18:48:47 PST
Created attachment 187454 [details]
Patch
Attachment 187454 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/style/NinePieceImage.cpp', u'Source/WebCore/rendering/style/NinePieceImage.h', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1
Source/WebCore/rendering/style/NinePieceImage.cpp:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/rendering/style/NinePieceImage.cpp:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/rendering/style/NinePieceImage.cpp:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/rendering/style/NinePieceImage.cpp:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/rendering/style/NinePieceImage.cpp:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/rendering/style/NinePieceImage.cpp:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/rendering/style/NinePieceImage.h:62: The parameter name "image" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 7 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 187454 [details] Patch Attachment 187454 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16475593 New failing tests: animations/cross-fade-border-image-source.html Comment on attachment 187454 [details]
Patch
Huh.
Comment on attachment 187454 [details] Patch Attachment 187454 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16474621 New failing tests: animations/cross-fade-border-image-source.html Created attachment 187464 [details]
Patch
Comment on attachment 187464 [details] Patch Clearing flags on attachment: 187464 Committed r142404: <http://trac.webkit.org/changeset/142404> All reviewed patches have been landed. Closing bug. |