Bug 109366

Summary: RenderStyle should use copy-on-write inheritance for NinePieceImage.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, kling, koivisto, ojan.autocc, webkit.review.bot
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
Patch none

Andreas Kling
Reported 2013-02-09 18:48:47 PST
Last night I had a dream about Antti telling me NinePieceImage should use copy-on-write inheritance.
Attachments
Patch (17.39 KB, patch)
2013-02-09 19:06 PST, Andreas Kling 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (17.76 KB, patch)
2013-02-09 22:47 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-02-09 19:06:14 PST
Created attachment 187454 [details] Patch
WebKit Review Bot
Comment 2 2013-02-09 19:15:35 PST
Attachment 187454 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/style/NinePieceImage.cpp', u'Source/WebCore/rendering/style/NinePieceImage.h', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1 Source/WebCore/rendering/style/NinePieceImage.cpp:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/style/NinePieceImage.cpp:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/style/NinePieceImage.cpp:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/style/NinePieceImage.cpp:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/style/NinePieceImage.cpp:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/style/NinePieceImage.cpp:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/style/NinePieceImage.h:62: The parameter name "image" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 7 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2013-02-09 20:23:44 PST
Comment on attachment 187454 [details] Patch Attachment 187454 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16475593 New failing tests: animations/cross-fade-border-image-source.html
Andreas Kling
Comment 4 2013-02-09 20:24:24 PST
Comment on attachment 187454 [details] Patch Huh.
WebKit Review Bot
Comment 5 2013-02-09 21:22:27 PST
Comment on attachment 187454 [details] Patch Attachment 187454 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16474621 New failing tests: animations/cross-fade-border-image-source.html
Andreas Kling
Comment 6 2013-02-09 22:47:02 PST
Created attachment 187464 [details] Patch
WebKit Review Bot
Comment 7 2013-02-10 08:06:22 PST
Comment on attachment 187464 [details] Patch Clearing flags on attachment: 187464 Committed r142404: <http://trac.webkit.org/changeset/142404>
WebKit Review Bot
Comment 8 2013-02-10 08:06:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.