Bug 109357

Summary: RenderText: Access characters through m_text instead of caching data pointers separately.
Product: WebKit Reporter: Andreas Kling <kling>
Component: TextAssignee: Andreas Kling <kling>
Severity: Normal CC: eric, kling, koivisto, ojan.autocc, webkit.review.bot
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Andreas Kling 2013-02-09 08:46:35 PST
The caching of String's is8Bit() and characters8()/characters16() on RenderText looks like a premature optimization.
We can save memory by going through m_text.*() instead. I see no measurable difference on PLT here.
Comment 1 Andreas Kling 2013-02-09 18:14:43 PST
Created attachment 187451 [details]
Comment 2 WebKit Review Bot 2013-02-10 05:45:39 PST
Comment on attachment 187451 [details]

Clearing flags on attachment: 187451

Committed r142398: <http://trac.webkit.org/changeset/142398>
Comment 3 WebKit Review Bot 2013-02-10 05:45:43 PST
All reviewed patches have been landed.  Closing bug.