Bug 10935

Summary:

REGRESSION: file upload control with direction:rtl or text-align:right draws button on top of filename/icon

Product:

WebKit

Reporter:

mitz

Component:

Forms

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben

Priority:

Keywords:

Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

data:text/html,<input%20type="file"%20style="direction:rtl;">

Attachments:

Description	Flags
Fix and new layout test	adele: review+

mitz

Reported 2006-09-19 11:08:30 PDT

When the direction property is set to rtl, the new file upload control aligns the button with the right edge of the control, which is arguably an improvement, but the filename and icon are positioned in a way that doesn't make sense, and are obscured by the button. Setting text-align to right or center also results in the filename being obscured by the button.

Attachments
Fix and new layout test (42.18 KB, patch) 2006-09-19 23:17 PDT, Adam Roben (:aroben)	adele: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2006-09-19 23:17:00 PDT

Created attachment 10661 [details] Fix and new layout test This patch fixes the positioning of the filename and icon in RTL layout, and forces text-align to match direction. It also adds a new layout test.

Adam Roben (:aroben)

Comment 2 2006-09-20 11:17:17 PDT

Mitz has verified the fix. Closing.

Adam Roben (:aroben)

Comment 3 2006-09-20 11:34:40 PDT

Landed as r16472, btw.

Note You need to log in before you can comment on or make changes to this bug.