Bug 109340 – Web Inspector: protocol should support setStyleText

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Timothy Hatcher]

You should be able to edit a whole CSSStyleDeclaration (like you can in the CSSOM with the cssText property).

Something like:

            {
                "name": "setStyleText",
                "parameters": [
                    { "name": "styleId", "$ref": "CSSStyleId" },
                    { "name": "text", "type": "string" },
                ],
                "returns": [
                    { "name": "style", "$ref": "CSSStyle", "description": "The resulting style after the text modification." }
                ],
                "description": "Sets the new <code>text</code> for the respective style."
            },

I understand you can get this crudely by using getStyleSheetText, replace the range gotten from the CSSStyle, then call setStyleSheetText. But that is fairly heavy handed, and would cause a world update for all rules in that stylesheet instead of a single rule.

Having this setStyleText call would allow features like free-form editing of inline styles or rules in the sidebar, instead of individual property editing.

[Timothy Hatcher]

I have a patch for this. Working on the test now.

[Timothy Hatcher]

Created attachment 198728 [details]
Patch

[Benjamin Poulain]

Comment on attachment 198728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198728&action=review

> Source/WebCore/inspector/InspectorCSSAgent.cpp:363
> +        : InspectorCSSAgent::StyleSheetAction("SetStyleText", styleSheet)

-> ASCIILiteral("SetStyleText") :)

[Timothy Hatcher]

Created attachment 198767 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 198767 [details]
Patch

Nice! r=me

[WebKit Commit Bot]

Comment on attachment 198767 [details]
Patch

Clearing flags on attachment: 198767

Committed r148723: <http://trac.webkit.org/changeset/148723>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.