Bug 109337 – Move plug-in enumeration back to the main thread

• Component: Plug-ins
• Status: RESOLVED FIXED

[Anders Carlsson]

Move plug-in enumeration back to the main thread

[Anders Carlsson]

Created attachment 187394 [details]
Patch

[Andreas Kling]

Comment on attachment 187394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187394&action=review

r=me. :'(

> Source/WebKit2/UIProcess/Storage/StorageManager.messages.in:27
> +    GetValues(uint64_t storageAreaID) -> (WebKit::StringPairVector values) DispatchOnConnectionQueue

This does not belong here.

[Anders Carlsson]

Committed r142339: <http://trac.webkit.org/changeset/142339>

[Alexey Proskuryakov]

Comment on attachment 187394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187394&action=review

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:-326
> -#if PLATFORM(MAC)
> -    // Add built-in PDF last, so that it's not used when a real plug-in is installed.
> -    // NOTE: This has to be done on the main thread as it calls localizedString().
> -    if (!m_context->omitPDFSupport()) {
> -#if ENABLE(PDFKIT_PLUGIN)
> -        plugins->append(PDFPlugin::pluginInfo());
> -#endif
> -        plugins->append(SimplePDFPlugin::pluginInfo());
> -    }
> -#endif

Where did this code go now?

[Alexey Proskuryakov]

Anders re-added it later in bug 109379.