Bug 109337

Summary: Move plug-in enumeration back to the main thread
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: Plug-insAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, kling, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Anders Carlsson 2013-02-08 18:28:08 PST 
Move plug-in enumeration back to the main thread
Comment 1 Anders Carlsson 2013-02-08 18:30:30 PST 
Created attachment 187394 [details]
Patch
Comment 2 Andreas Kling 2013-02-08 18:32:59 PST 
Comment on attachment 187394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187394&action=review

r=me. :'(

> Source/WebKit2/UIProcess/Storage/StorageManager.messages.in:27
> +    GetValues(uint64_t storageAreaID) -> (WebKit::StringPairVector values) DispatchOnConnectionQueue

This does not belong here.
Comment 3 Anders Carlsson 2013-02-08 18:35:46 PST 
Committed r142339: <http://trac.webkit.org/changeset/142339>
Comment 4 Alexey Proskuryakov 2013-02-08 20:41:17 PST 
Comment on attachment 187394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187394&action=review

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:-326
> -#if PLATFORM(MAC)
> -    // Add built-in PDF last, so that it's not used when a real plug-in is installed.
> -    // NOTE: This has to be done on the main thread as it calls localizedString().
> -    if (!m_context->omitPDFSupport()) {
> -#if ENABLE(PDFKIT_PLUGIN)
> -        plugins->append(PDFPlugin::pluginInfo());
> -#endif
> -        plugins->append(SimplePDFPlugin::pluginInfo());
> -    }
> -#endif

Where did this code go now?
Comment 5 Alexey Proskuryakov 2013-02-10 12:48:48 PST 
Anders re-added it later in bug 109379.