Bug 109331

Summary: EXT_draw_buffers needs implementation
Product: WebKit Reporter: Remi Arnaud <Remi.Arnaud>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bajones, cc-bugs, cmarrin, ddkilzer, dglazkov, dino, esprehn+autocc, fishd, gman, gyuyoung.kim, haraken, jamesr, japhet, kbr, noam, ojan.autocc, philn, rakuco, tkent+wkapi, webkit-ews, webkit.review.bot, xan.lopez, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.khronos.org/registry/webgl/extensions/EXT_draw_buffers/
Bug Depends on:    
Bug Blocks: 111093    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch kbr: review+, kbr: commit-queue-

Description Remi Arnaud 2013-02-08 16:03:36 PST
EXT_draw_buffers (see URL) is in Draft stage, and is awaiting implementation to enable the community to review the extension.

EXT_draw_buffers in used in deferred rendering techniques, enabling many light sources to be used to greatly enhance the quality of the scene. Many developers are looking forward to this extension in order to enable them to provide rendering quality on par with what the device can do with native applications.
Comment 1 Zhenyao Mo 2013-02-12 16:22:22 PST
I'll take this one.
Comment 2 Zhenyao Mo 2013-02-26 13:06:54 PST
Created attachment 190346 [details]
Patch
Comment 3 Zhenyao Mo 2013-02-26 13:52:46 PST
Created attachment 190354 [details]
Patch
Comment 4 WebKit Review Bot 2013-02-26 13:56:51 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 Early Warning System Bot 2013-02-26 13:58:38 PST
Comment on attachment 190354 [details]
Patch

Attachment 190354 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16777419
Comment 6 Early Warning System Bot 2013-02-26 14:01:18 PST
Comment on attachment 190354 [details]
Patch

Attachment 190354 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16770487
Comment 7 EFL EWS Bot 2013-02-26 14:17:16 PST
Comment on attachment 190354 [details]
Patch

Attachment 190354 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/16771446
Comment 8 Zhenyao Mo 2013-02-26 14:30:15 PST
Created attachment 190363 [details]
Patch
Comment 9 Early Warning System Bot 2013-02-26 14:36:19 PST
Comment on attachment 190363 [details]
Patch

Attachment 190363 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16772505
Comment 10 Early Warning System Bot 2013-02-26 14:42:00 PST
Comment on attachment 190363 [details]
Patch

Attachment 190363 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16780414
Comment 11 Zhenyao Mo 2013-02-26 14:49:31 PST
Created attachment 190366 [details]
Patch
Comment 12 WebKit Review Bot 2013-02-26 15:05:07 PST
Attachment 190366 [details] did not pass style-queue:

Source/WebCore/platform/graphics/Extensions3D.h:154:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:157:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:158:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:159:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:160:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:161:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:162:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:163:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:164:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:165:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:166:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:167:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:168:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:169:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:170:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:171:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:172:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:173:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:174:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:175:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:176:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:177:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:178:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:179:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:180:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:181:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:182:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platform/chromium/public/WebGraphicsContext3D.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/bindings/v8/V8Binding.h', u'Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/EXTDrawBuffers.cpp', u'Source/WebCore/html/canvas/EXTDrawBuffers.h', u'Source/WebCore/html/canvas/EXTDrawBuffers.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLFramebuffer.cpp', u'Source/WebCore/html/canvas/WebGLFramebuffer.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/platform/chromium/support/Extensions3DChromium.cpp', u'Source/WebCore/platform/graphics/Extensions3D.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.cpp', u'Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h']" exit_code: 1
form/graphics/Extensions3D.h:183:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:184:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:185:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:186:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:187:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:188:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:189:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:190:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 35 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Zhenyao Mo 2013-02-26 15:08:41 PST
Created attachment 190370 [details]
Patch
Comment 14 WebKit Review Bot 2013-02-26 15:13:53 PST
Attachment 190370 [details] did not pass style-queue:

Source/WebCore/platform/graphics/Extensions3D.h:154:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:157:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:158:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:159:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:160:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:161:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:162:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:163:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:164:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:165:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:166:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:167:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:168:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:169:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:170:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:171:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:172:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:173:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:174:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:175:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:176:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:177:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:178:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:179:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:180:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:181:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:182:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platform/chromium/public/WebGraphicsContext3D.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/bindings/v8/V8Binding.h', u'Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/EXTDrawBuffers.cpp', u'Source/WebCore/html/canvas/EXTDrawBuffers.h', u'Source/WebCore/html/canvas/EXTDrawBuffers.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLFramebuffer.cpp', u'Source/WebCore/html/canvas/WebGLFramebuffer.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/platform/chromium/support/Extensions3DChromium.cpp', u'Source/WebCore/platform/graphics/Extensions3D.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.cpp', u'Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h']" exit_code: 1
form/graphics/Extensions3D.h:183:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:184:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:185:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:186:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:187:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:188:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:189:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:190:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 35 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 Zhenyao Mo 2013-02-26 16:42:26 PST
Created attachment 190391 [details]
Patch
Comment 16 WebKit Review Bot 2013-02-26 16:47:03 PST
Attachment 190391 [details] did not pass style-queue:

Source/WebCore/platform/graphics/Extensions3D.h:154:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:157:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:158:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:159:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:160:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:161:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:162:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:163:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:164:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:165:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:166:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:167:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:168:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:169:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:170:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:171:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:172:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:173:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:174:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:175:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:176:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:177:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:178:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:179:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:180:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:181:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:182:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platform/chromium/public/WebGraphicsContext3D.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/bindings/v8/V8Binding.h', u'Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/EXTDrawBuffers.cpp', u'Source/WebCore/html/canvas/EXTDrawBuffers.h', u'Source/WebCore/html/canvas/EXTDrawBuffers.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLFramebuffer.cpp', u'Source/WebCore/html/canvas/WebGLFramebuffer.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/platform/chromium/support/Extensions3DChromium.cpp', u'Source/WebCore/platform/graphics/Extensions3D.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.cpp', u'Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h']" exit_code: 1
form/graphics/Extensions3D.h:183:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:184:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:185:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:186:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:187:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:188:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:189:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:190:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 35 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 Zhenyao Mo 2013-02-26 17:09:42 PST
gtk failure: execvp: ../../Source/WebCore/html/canvas/EXTDrawBuffers.idl: Permission denied

anyone knows how to fix this?
Comment 18 Zhenyao Mo 2013-02-27 10:00:20 PST
Created attachment 190550 [details]
Patch
Comment 19 WebKit Review Bot 2013-02-27 10:04:22 PST
Attachment 190550 [details] did not pass style-queue:

Source/WebCore/platform/graphics/Extensions3D.h:154:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:157:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:158:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:159:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:160:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:161:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:162:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:163:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:164:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:165:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:166:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:167:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:168:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:169:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:170:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:171:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:172:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:173:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:174:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:175:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:176:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:177:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:178:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:179:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:180:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:181:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:182:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/bindings/v8/V8Binding.h', u'Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/EXTDrawBuffers.cpp', u'Source/WebCore/html/canvas/EXTDrawBuffers.h', u'Source/WebCore/html/canvas/EXTDrawBuffers.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLFramebuffer.cpp', u'Source/WebCore/html/canvas/WebGLFramebuffer.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/platform/chromium/support/Extensions3DChromium.cpp', u'Source/WebCore/platform/graphics/Extensions3D.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.cpp', u'Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h']" exit_code: 1
form/graphics/Extensions3D.h:183:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:184:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:185:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:186:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:187:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:188:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:189:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:190:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 35 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 20 WebKit Review Bot 2013-02-27 10:12:44 PST
Comment on attachment 190550 [details]
Patch

Attachment 190550 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16758149
Comment 21 Zhenyao Mo 2013-02-27 10:48:54 PST
Created attachment 190555 [details]
Patch
Comment 22 WebKit Review Bot 2013-02-27 10:53:46 PST
Attachment 190555 [details] did not pass style-queue:

Source/WebCore/platform/graphics/Extensions3D.h:154:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:157:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:158:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:159:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:160:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:161:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:162:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:163:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:164:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:165:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:166:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:167:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:168:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:169:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:170:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:171:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:172:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:173:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:174:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:175:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:176:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:177:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:178:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:179:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:180:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:181:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:182:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platform/chromium/public/WebGraphicsContext3D.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/bindings/v8/V8Binding.h', u'Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/EXTDrawBuffers.cpp', u'Source/WebCore/html/canvas/EXTDrawBuffers.h', u'Source/WebCore/html/canvas/EXTDrawBuffers.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLFramebuffer.cpp', u'Source/WebCore/html/canvas/WebGLFramebuffer.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/platform/chromium/support/Extensions3DChromium.cpp', u'Source/WebCore/platform/graphics/Extensions3D.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.cpp', u'Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h']" exit_code: 1
form/graphics/Extensions3D.h:183:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:184:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:185:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:186:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:187:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:188:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:189:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:190:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 35 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 23 Kenneth Russell 2013-02-27 16:17:16 PST
Comment on attachment 190555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190555&action=review

Looks good. r=me with a couple of minor modifications.

> Source/Platform/chromium/public/WebGraphicsContext3D.h:476
> +    virtual void drawBuffersChromium(WGC3Dsizei n, const WGC3Denum* bufs) { }

Capitalization doesn't follow the naming convention elsewhere in this file. Should either be drawBuffersCHROMIUM or, if semantics don't differ from EXT_draw_buffers, drawBuffersEXT.

> Source/WebCore/bindings/v8/V8Binding.h:246
> +    // Convert a value to a 32-bit integer. The conversion fails if the

Note to other reviewers: these helpers had to be moved higher in the file to allow "unsigned nativeValue(...)", below, to be defined. The JSC bindings already exposed this conversion.

> Source/WebCore/html/canvas/EXTDrawBuffers.cpp:53
> +    return adoptPtr(x);

This should just read "adoptPtr(new EXTDrawBuffers(context));". The point of adoptPtr is to ensure there are no "naked news" in the code base.

> Source/WebCore/html/canvas/EXTDrawBuffers.cpp:78
> +        // Because the backbuffer is simulated we need to change BACK to COLOR_ATTACHMENT0

It's probably worth saying: "Because the backbuffer is simulated on all current WebKit ports, ...". Also, please end the comment with a period.

> Source/WebCore/html/canvas/WebGLFramebuffer.cpp:607
> +    for (size_t i = 0; i < m_drawBuffers.size(); i++) {

Please add a comment indicating that this filtering works around graphics driver bugs on Mac OS X. I assume it is sufficient to do so? Also, it's important that it be possible to disable this workaround at run time so that we can file a Radar about it. Since it looks like that will involve adding a lot of infrastructure, please file another WebKit bug for that and make it depend on this one.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:5396
> +    // COLOR_ATTACHMENT0_EXT is equal to COLOR_ATTACHMENT0

Please indent and add period.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:5924
> +    if (!m_maxDrawBuffers && EXTDrawBuffers::supported(this))

Theoretically, this and getMaxColorAttachments should also be calling m_context->getExtensions()->ensureEnabled("GL_EXT_draw_buffers"), but that would really only be needed in the Chromium port and it will work without it, so maybe best not to bother.

>> Source/WebCore/platform/graphics/Extensions3D.h:154
>> +        UNPACK_UNPREMULTIPLY_ALPHA_CHROMIUM = 0x9242,
> 
> enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]

Note to other reviewers: the enums in this file follow the OpenGL naming convention, so I'm ignoring the reported style errors.
Comment 24 Zhenyao Mo 2013-02-28 10:47:28 PST
Comment on attachment 190555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190555&action=review

>> Source/Platform/chromium/public/WebGraphicsContext3D.h:476
>> +    virtual void drawBuffersChromium(WGC3Dsizei n, const WGC3Denum* bufs) { }
> 
> Capitalization doesn't follow the naming convention elsewhere in this file. Should either be drawBuffersCHROMIUM or, if semantics don't differ from EXT_draw_buffers, drawBuffersEXT.

Use drawBuffersEXT

>> Source/WebCore/html/canvas/EXTDrawBuffers.cpp:53
>> +    return adoptPtr(x);
> 
> This should just read "adoptPtr(new EXTDrawBuffers(context));". The point of adoptPtr is to ensure there are no "naked news" in the code base.

Done

>> Source/WebCore/html/canvas/EXTDrawBuffers.cpp:78
>> +        // Because the backbuffer is simulated we need to change BACK to COLOR_ATTACHMENT0
> 
> It's probably worth saying: "Because the backbuffer is simulated on all current WebKit ports, ...". Also, please end the comment with a period.

Done

>> Source/WebCore/html/canvas/WebGLFramebuffer.cpp:607
>> +    for (size_t i = 0; i < m_drawBuffers.size(); i++) {
> 
> Please add a comment indicating that this filtering works around graphics driver bugs on Mac OS X. I assume it is sufficient to do so? Also, it's important that it be possible to disable this workaround at run time so that we can file a Radar about it. Since it looks like that will involve adding a lot of infrastructure, please file another WebKit bug for that and make it depend on this one.

Done.  https://bugs.webkit.org/show_bug.cgi?id=111093

>> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:5396
>> +    // COLOR_ATTACHMENT0_EXT is equal to COLOR_ATTACHMENT0
> 
> Please indent and add period.

Done.
Comment 25 Zhenyao Mo 2013-02-28 13:37:27 PST
Committed r144358: <http://trac.webkit.org/changeset/144358>
Comment 26 David Kilzer (:ddkilzer) 2013-03-01 08:30:42 PST
(In reply to comment #25)
> Committed r144358: <http://trac.webkit.org/changeset/144358>

Build fix in r144459:  <http://trac.webkit.org/changeset/144459>