Bug 109321

Summary: [GTK] Build errors in TextureMapperShaderProgram.cpp when compiling with Clang
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109314    
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2013-02-08 13:20:54 PST
The build fails in TextureMapperShaderProgram.cpp when building with Clang at the following code: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp#L76 The errors being thrown out: ../../Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:81:9: error: non-constant-expression cannot be narrowed from type 'double' to 'GC3Dfloat' (aka 'float') in initializer list matrix.m11(), matrix.m12(), matrix.m13(), matrix.m14(), ^~~~~~~~~~~~ ../../Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:81:9: note: override this message by inserting an explicit cast matrix.m11(), matrix.m12(), matrix.m13(), matrix.m14(), ^~~~~~~~~~~~ static_cast<)C3Dfloat>( ../../Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:81:23: error: non-constant-expression cannot be narrowed from type 'double' to 'GC3Dfloat' (aka 'float') in initializer list matrix.m11(), matrix.m12(), matrix.m13(), matrix.m14(), ^~~~~~~~~~~~ ../../Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:81:23: note: override this message by inserting an explicit cast matrix.m11(), matrix.m12(), matrix.m13(), matrix.m14(), ^~~~~~~~~~~~ static_cast<)C3Dfloat>( (... and so on for the other 14 arguments as well).
Attachments
Patch (2.57 KB, patch)
2013-02-08 13:37 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (2.28 KB, patch)
2013-02-10 01:14 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-02-08 13:37:29 PST
Created attachment 187358 [details] Patch
Noam Rosenthal
Comment 2 2013-02-09 03:04:07 PST
implicit constructors would also work, without an additional "as" function: GC3Dfloat(double)
Zan Dobersek
Comment 3 2013-02-10 01:07:06 PST
(In reply to comment #2) > implicit constructors would also work, without an additional "as" function: > GC3Dfloat(double) I guess you meant explicit constructors. They work indeed, I'll upload a patch with those being used.
Zan Dobersek
Comment 4 2013-02-10 01:14:43 PST
Created attachment 187470 [details] Patch
Zan Dobersek
Comment 5 2013-02-10 02:42:08 PST
Comment on attachment 187470 [details] Patch Clearing flags on attachment: 187470 Committed r142392: <http://trac.webkit.org/changeset/142392>
Zan Dobersek
Comment 6 2013-02-10 02:42:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.