Summary: | REGRESSION (r132422): Page content and scrollbars are incorrectly offset after restoring a page from the page cache | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
Component: | Layout and Rendering | Assignee: | Tim Horton <thorton> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bdakin, beidson, sam, simon.fraser | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tim Horton
2013-02-08 13:08:36 PST
Created attachment 187357 [details]
preliminary patch (breaks at least one test, needs a test of its own)
Created attachment 187471 [details]
with a test
Comment on attachment 187471 [details] with a test View in context: https://bugs.webkit.org/attachment.cgi?id=187471&action=review > LayoutTests/platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html:17 > + log += internals.layerTreeAsText(window.document, internals.LAYER_TREE_INCLUDES_VISIBLE_RECTS | internals.LAYER_TREE_INCLUDES_TILE_CACHES); Should check for internals' existence here. > LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html:14 > + if (window.internals) Don't need this line. Comment on attachment 187471 [details] with a test View in context: https://bugs.webkit.org/attachment.cgi?id=187471&action=review > LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html:22 > + window.open("resources/scroll-and-load-page.html"); Do you need to use window.open? Can't you just scroll, load another page that goes back, then finish the test? > Tools/ChangeLog:9 > + WebKitTestRunner should propagate window creation options to subwindows (so that children of tiled-drawing windows use tiled drawing, in this case). This should really be a separate patch. > Tools/WebKitTestRunner/PlatformWebView.h:98 > + WKDictionaryRef options() { return m_options.get(); } const? (In reply to comment #4) > (From update of attachment 187471 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187471&action=review > > > LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html:22 > > + window.open("resources/scroll-and-load-page.html"); > > Do you need to use window.open? Can't you just scroll, load another page that goes back, then finish the test? I'm not sure why that didn't work; it looked like the first page (the one that turns on the page cache) wasn't getting put *into* the page cache. So I followed suit with the other page-cache-testing tests and turned it on, then opened a new window. Maybe Brady knows. > > Tools/ChangeLog:9 > > + WebKitTestRunner should propagate window creation options to subwindows (so that children of tiled-drawing windows use tiled drawing, in this case). > > This should really be a separate patch. Yerp. > > Tools/WebKitTestRunner/PlatformWebView.h:98 > > + WKDictionaryRef options() { return m_options.get(); } > > const? Sure. Created attachment 187490 [details]
patch
|