[chromium] move context menu data tracking to TestRunner library

• Component: New Bugs
• Status: RESOLVED FIXED

[chromium] move context menu data tracking to TestRunner library

Created attachment 187345 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 187345 [details]
Patch

Clearing flags on attachment: 187345

Committed r142371: <http://trac.webkit.org/changeset/142371>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kent Tamura]

It broke a clang build:

FAILED: /b/build/goma/gomacc /mnt/data/b/build/slave/android_clang_dbg/build/src/third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/WebKit/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.TestInterfaces.o.d -D_FILE_OFFSET_BITS=64 -DUSE_LINUX_BREAKPAD -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_THREADING -DDCHECK_ALWAYS_ON=1 -DENABLE_GPU=1 -DUSE_OPENSSL=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DWEBTESTRUNNER_IMPLEMENTATION=1 -DSK_BUILD_NO_IMAGE_ENCODE -DSK_DEFERRED_CANVAS_USES_GPIPE=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DGR_AGGRESSIVE_SHADER_OPTS=1 -DSK_ENABLE_INST_COUNT=0 -DSK_USE_POSIX_THREADS -DSK_BUILD_FOR_ANDROID_NDK -DHAVE_ENDIAN_H -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DANDROID -D__GNU_SOURCE=1 -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 '-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -I../../third_party/icu/public/common -I../.. -I../../third_party/WebKit/Source/WebKit/chromium/public -I../../third_party/WebKit/Tools/DumpRenderTree/chromium/TestRunner/public -I../../third_party/WebKit/Tools/DumpRenderTree/chromium/TestRunner/src -I../../third_party/WebKit/Source -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source/Platform/chromium -I../../third_party/WebKit/Source/Platform/chromium -Igen/webcore_headers -I../../skia/config -I../../third_party/skia/src/core -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/gpu/gl -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../v8/include -Wunused-parameter -fstack-protector --param=ssp-buffer-size=4 -Werror -fno-exceptions -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wheader-hygiene -Wno-unused-function -Wno-char-subscripts -Wno-unnamed-type-template-args -Wno-c++11-extensions -Wno-covered-switch-default -Xclang -load -Xclang /mnt/data/b/build/slave/android_clang_dbg/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang skip-virtuals-in-implementations -fcolor-diagnostics -Wno-format -mthumb -march=armv7-a -mtune=cortex-a8 -mfloat-abi=softfp -mfpu=vfpv3-d16 -ffunction-sections -funwind-tables -g -fstack-protector -fno-short-enums -Wa,--noexecstack -D__compiler_offsetof=__builtin_offsetof -Dnan=__builtin_nan -target arm-linux-androideabi -mllvm -arm-enable-ehabi --sysroot=/mnt/data/b/build/slave/android_clang_dbg/build/src/third_party/android_tools/ndk//platforms/android-9/arch-arm -I/mnt/data/b/build/slave/android_clang_dbg/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport -I/mnt/data/b/build/slave/android_clang_dbg/build/src/third_party/android_tools/ndk//sources/cxx-stl/gnu-libstdc++/4.6/include -Os -g -fomit-frame-pointer -fdata-sections -ffunction-sections -g0 -Wno-c++0x-compat -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wno-deprecated -Wno-abi  -c ../../third_party/WebKit/Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp -o obj/third_party/WebKit/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.TestInterfaces.o
In file included from ../../third_party/WebKit/Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:32:
In file included from ../../third_party/WebKit/Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:34:
In file included from /mnt/data/b/build/slave/android_clang_dbg/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport/memory:40:
/mnt/data/b/build/slave/android_clang_dbg/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport/stl/_auto_ptr.h:107:70:error: deleting pointer to incomplete type 'WebKit::WebContextMenuData' may cause undefined behavior [-Werror,-Wdelete-incomplete]
  ~auto_ptr() _STLP_NOTHROW { /* boris : reset(0) might be better */ delete this->get(); }
                                                                     ^      ~~~~~~~~~~~
../../third_party/WebKit/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.h:57:7: note: in instantiation of member function 'std::auto_ptr<WebKit::WebContextMenuData>::~auto_ptr' requested here
class EventSender : public CppBoundClass {
      ^
../../third_party/WebKit/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.h:50:8: note: forward declaration of 'WebKit::WebContextMenuData'
struct WebContextMenuData;
       ^
1 error generated.


Fix: http://trac.webkit.org/changeset/142403