Bug 109282

Summary:

Web Inspector: Introduce workspace provider/project type, encapsulate uri creation in SimpleWorkspaceProvider.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Vsevolod Vlasov <vsevik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	apavlov: review+

Vsevolod Vlasov

Reported 2013-02-08 03:40:37 PST

SimpleWorkspaceProvider now fully takes care of creating uri based on project/workspace provider type. This is the first step on the way to project-per-domain mode for non file system project types.

Attachments
Patch (44.24 KB, patch) 2013-02-08 03:45 PST, Vsevolod Vlasov	no flags	Details Formatted Diff Diff
Patch (45.25 KB, patch) 2013-02-08 03:55 PST, Vsevolod Vlasov	no flags	Details Formatted Diff Diff
Patch (45.15 KB, patch) 2013-02-08 04:00 PST, Vsevolod Vlasov	apavlov: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Vsevolod Vlasov

Comment 1 2013-02-08 03:45:49 PST

Created attachment 187282 [details] Patch

Vsevolod Vlasov

Comment 2 2013-02-08 03:55:56 PST

Created attachment 187284 [details] Patch

Vsevolod Vlasov

Comment 3 2013-02-08 04:00:19 PST

Created attachment 187285 [details] Patch

Alexander Pavlov (apavlov)

Comment 4 2013-02-08 04:40:35 PST

Comment on attachment 187285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187285&action=review > Source/WebCore/ChangeLog:11 > + Drive-by: ScriptsPanel now uses FileMApping to show anchor location properly. FileMapping > Source/WebCore/inspector/front-end/SimpleWorkspaceProvider.js:141 > + odd line > Source/WebCore/inspector/front-end/Workspace.js:337 > + result = result.concat(project.uiSourceCodes()); result.push.apply(result, project.uiSourceCodes());

Vsevolod Vlasov

Comment 5 2013-02-08 06:12:34 PST

Committed r142269: <http://trac.webkit.org/changeset/142269>

Note You need to log in before you can comment on or make changes to this bug.