Bug 109274

Summary:

[CSSRegions] Text highlight in regions is wrong

Product:

WebKit

Reporter:

Mihnea Ovidenie <mihnea>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WORKSFORME

Severity:

Normal

CC:

jfernandez, rego, WebkitBugTracker

Priority:

Keywords:

AdobeTracked

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Wrong paint for selection in region	none
Correct painted selection outside the region	none
Patch	none

Mihnea Ovidenie

Reported 2013-02-08 01:51:41 PST

If you search for a word inside a region, the highlighted selection is painted wrong, as opposed to the case where the highlighted word is outside the region, see attached images.

Attachments
Wrong paint for selection in region (61.28 KB, image/png) 2013-02-08 01:53 PST, Mihnea Ovidenie	no flags	Details
Correct painted selection outside the region (61.27 KB, image/png) 2013-02-08 01:53 PST, Mihnea Ovidenie	no flags	Details
Patch (2.94 KB, patch) 2013-09-04 15:43 PDT, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mihnea Ovidenie

Comment 1 2013-02-08 01:53:02 PST

Created attachment 187269 [details] Wrong paint for selection in region

Mihnea Ovidenie

Comment 2 2013-02-08 01:53:48 PST

Created attachment 187270 [details] Correct painted selection outside the region

Javier Fernandez

Comment 3 2013-08-13 14:02:44 PDT

Well, I had to apply the patch posted at bug 117631 but I can confirm this bug is not reproducible in the Gtk+ port.

Mihnea Ovidenie

Comment 4 2013-08-27 08:09:01 PDT

(In reply to comment #3) > Well, I had to apply the patch posted at bug 117631 but I can confirm this bug is not reproducible in the Gtk+ port. Looks like it does not repro from nightly r151344.

Mihnea Ovidenie

Comment 5 2013-08-27 12:43:31 PDT

Fixed by http://trac.webkit.org/changeset/151309, i believe it deserves a test.

Manuel Rego Casasnovas

Comment 6 2013-09-04 15:43:38 PDT

Created attachment 210503 [details] Patch

Mihnea Ovidenie

Comment 7 2013-09-23 08:34:04 PDT

(In reply to comment #6) > Created an attachment (id=210503) [details] > Patch Actually, the problem is the way the focus ring around the searched text is painted. I don't think that your test is testing that. Here is the original sample i used to reproduce the problem: <html> <head> <style> #article { -webkit-flow-into: flow; } #region { -webkit-flow-from: flow; width: 100px; height: 100px; position: absolute; top: 10px; left: 10px; } </style> </head> <body> <div id="article">Text inside article</div> <div id="region"></div> </body> </html> I am not sure how to test the focus ring though.

Manuel Rego Casasnovas

Comment 8 2013-10-01 04:43:51 PDT

(In reply to comment #7) > (In reply to comment #6) > > Created an attachment (id=210503) [details] [details] > > Patch > > Actually, the problem is the way the focus ring around the searched text is painted. I don't think that your test is testing that. Focus ring seems to be something particular from Mac port. > I am not sure how to test the focus ring though. Sorry but I don't know how to test it either :-(

Manuel Rego Casasnovas

Comment 9 2014-04-23 03:03:08 PDT

Comment on attachment 210503 [details] Patch Clearing flags.

Note You need to log in before you can comment on or make changes to this bug.