Bug 109272

Summary: [Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dtrebbien, haraken, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch haraken: review+, webkit.review.bot: commit-queue-

Kent Tamura
Reported 2013-02-08 01:35:04 PST
[Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
Attachments
Patch (3.11 KB, patch)
2013-02-08 01:44 PST, Kent Tamura 		haraken: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2013-02-08 01:44:44 PST
Created attachment 187266 [details] Patch
Kentaro Hara
Comment 2 2013-02-08 01:59:16 PST
Comment on attachment 187266 [details] Patch ok
WebKit Review Bot
Comment 3 2013-02-08 03:33:28 PST
Comment on attachment 187266 [details] Patch Attachment 187266 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16426608 New failing tests: platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-step-attribute.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-min-max-attribute.html platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html
WebKit Review Bot
Comment 4 2013-02-08 04:36:11 PST
Comment on attachment 187266 [details] Patch Attachment 187266 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16431562 New failing tests: platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-step-attribute.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-min-max-attribute.html platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance.html platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html
Kent Tamura
Comment 5 2013-02-08 05:06:52 PST
> New failing tests: > platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl.html > platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-step-attribute.html > platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html > platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew.html > platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html > platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar.html > platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-min-max-attribute.html > platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html > platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html > platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance.html > platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html As you can imagine, they should be listed in TestExpectations.
Kent Tamura
Comment 6 2013-02-08 09:14:20 PST
Committed r142290: <http://trac.webkit.org/changeset/142290>
Note You need to log in before you can comment on or make changes to this bug.