Bug 10927

Summary:

ResourceLoaderClient::receivedRedirect is never called

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

OS:

Windows XP

Bug Depends on:

Bug Blocks:

10744

Attachments:

Description	Flags
patch	none
revised patch per feedback from maciej	beidson: review-
New patch with some small (critical) fixes	none

Darin Fisher (:fishd, Google)

Reported 2006-09-18 18:37:32 PDT

ResourceLoaderClient::receivedRedirect is never called

Attachments
patch (17.10 KB, patch) 2006-09-18 19:22 PDT, Darin Fisher (:fishd, Google)	no flags	Details Formatted Diff Diff
revised patch per feedback from maciej (17.92 KB, patch) 2006-09-21 16:57 PDT, Darin Fisher (:fishd, Google)	beidson: review-	Details Formatted Diff Diff
New patch with some small (critical) fixes (18.20 KB, patch) 2006-09-21 18:17 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Fisher (:fishd, Google)

Comment 1 2006-09-18 18:39:30 PDT

Related to this bug is the fact that IWebFrameLoadDelegate's didReceiveServerRedirectForProvisionalLoadForFrame method is not called. (Man, that's a long method name!)

Darin Fisher (:fishd, Google)

Comment 2 2006-09-18 19:22:31 PDT

Created attachment 10636 [details] patch This patch makes it so that client()->receivedRedirect is called. I also took a stab at cleaning up the large WndProc in ResourceLoaderWin.cpp. I found a way to avoid the heap-allocated struct passed to PostMessage, and I also got rid of the unnecessary call to RegisterWindowMessage, replacing it with WM_USER + N. I hope you will consider these changes as I believe they make ResourceLoaderWin.cpp much more manageable. The code for INTERNET_STATUS_USER_INPUT_REQUIRED is needed in case WinInet is configured to prompt on security warnings, etc.

Darin Fisher (:fishd, Google)

Comment 3 2006-09-19 18:58:25 PDT

It turns out that this patch also fixes bug 10744. That bug is caused by the fact that we do not respond to INTERNET_STATUS_USER_INPUT_REQUIRED.

Darin Fisher (:fishd, Google)

Comment 4 2006-09-21 16:57:22 PDT

Created attachment 10697 [details] revised patch per feedback from maciej Revised patch. Got rid of "k" prefixes on variables. Switched from UINT to int where appropriate.

Brady Eidson

Comment 5 2006-09-21 17:44:02 PDT

Comment on attachment 10697 [details] revised patch per feedback from maciej This is pretty good, but it misses one important thing - note my follow up patch and how it sets the error code in the ResourceLoader (which is used elsewhere!)

Brady Eidson

Comment 6 2006-09-21 18:17:25 PDT

Created attachment 10698 [details] New patch with some small (critical) fixes I think I can get someone else to review this tonite (I'll email the team)

Darin Fisher (:fishd, Google)

Comment 7 2006-09-21 18:33:20 PDT

Please note the changes between my first and second patches. The latest patch undoes the changes that Maciej recommended.

Brady Eidson

Comment 8 2006-09-22 11:28:06 PDT

I completely didn't realize that there was a follow up that contained feedback from maciej. I just checked in my version, but I will go back and merge the changes maciej originally requested into what I decided on

Brady Eidson

Comment 9 2006-09-22 16:29:32 PDT

Commited in r16526

Adam Roben (:aroben)

Comment 10 2006-09-26 09:15:16 PDT

Comment on attachment 10698 [details] New patch with some small (critical) fixes Clearing review flag

Note You need to log in before you can comment on or make changes to this bug.