Bug 109263

Summary:

Web Inspector: Native Memory Instrumentation: adjust chunk transfer size for better speed.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

107254

Attachments:

Description	Flags
Patch	yurys: review+

Description Ilya Tikhonovsky 2013-02-07 23:51:08 PST

With the current values the snapshot on gmail requires about 27sec.
This operation could be 30 times faster if we increase the chunk size from 100 items to 10000.
Also very long strings will significantly affect the transfer size.

Comment 1 Ilya Tikhonovsky 2013-02-08 00:07:57 PST

Created attachment 187251 [details]
Patch

Comment 2 Yury Semikhatsky 2013-02-08 00:11:31 PST

(In reply to comment #0)
> With the current values the snapshot on gmail requires about 27sec.
> This operation could be 30 times faster if we increase the chunk size from 100 items to 10000.
What would be an average message size in bytes in this case?

Comment 3 Ilya Tikhonovsky 2013-02-08 00:17:51 PST

sizeof(int) * 10000 * nodeFieldCount = 200kb
sizeof(int) * 10000 * edgeFieldCount = 120kb
sizeof(int) * 10000 * idMapEntryFieldCount = 80kb
sizeof(String) * 1000 = 80kb

So the expected working set for the serializer is ~480kb

Comment 4 Ilya Tikhonovsky 2013-02-08 00:19:48 PST

Committed r142241: <http://trac.webkit.org/changeset/142241>