| Summary: | Fix TextDocumentParser to play nice with threading | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||||
| Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, buildbot, dglazkov, ojan.autocc, rniwa, tonyg, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 106127 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eric Seidel (no email)
2013-02-07 16:20:34 PST
Created attachment 187195 [details]
Patch
I'm not 100% sure that the line number change isn't detectable, but this approach is much cleaner. This only affects the column number, and only on the first line. But I don't think the line numbers during TextDocument parsing are ever used by the rest of WebCore, even in the inspector. Comment on attachment 187195 [details] Patch Attachment 187195 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16434391 New failing tests: fast/tokenizer/text-plain.html http/tests/security/xss-DENIED-mime-type-execute-as-html.html http/tests/misc/acid3.html Created attachment 187207 [details]
Patch for landing
Comment on attachment 187207 [details] Patch for landing Attachment 187207 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16438419 New failing tests: fast/text/plain-text-line-breaks.html fast/forms/targeted-frame-submission.html fast/loader/text-document-wrapping.html Comment on attachment 187207 [details] Patch for landing Attachment 187207 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16448010 New failing tests: fast/text/plain-text-line-breaks.html fast/forms/targeted-frame-submission.html http/tests/misc/acid3.html fast/loader/text-document-wrapping.html *** Bug 107330 has been marked as a duplicate of this bug. *** Created attachment 187338 [details]
Patch for landing
Comment on attachment 187338 [details]
Patch for landing
This conflicts with the WeakPtr patch. I'll merge manually.
Created attachment 187342 [details]
Patch for landing
Comment on attachment 187342 [details] Patch for landing Clearing flags on attachment: 187342 Committed r142363: <http://trac.webkit.org/changeset/142363> All reviewed patches have been landed. Closing bug. |